Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 961483004: Fix multi-touch to work in SkyShell. (Closed)

Created:
5 years, 10 months ago by eseidel
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix multi-touch to work in SkyShell. Before this patch it crashed. Also updated the touch-demo to support multi-touch. R=abarth@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/968d4d344c05b76bf61a048af8debdc6f3ea3052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -22 lines) Patch
M sky/engine/core/dom/ParentNode.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/frame/NewEventHandler.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/examples/touch-demo.sky View 1 chunk +37 lines, -10 lines 0 comments Download
M sky/shell/apk/src/org/domokit/sky/shell/PlatformView.java View 3 chunks +31 lines, -5 lines 0 comments Download
M sky/shell/apk/src/org/domokit/sky/shell/SkyShellActivity.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 10 months ago (2015-02-26 01:21:12 UTC) #1
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-26 01:23:35 UTC) #2
eseidel
5 years, 10 months ago (2015-02-26 20:23:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
968d4d344c05b76bf61a048af8debdc6f3ea3052 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698