Throttle script request incidents to one per user.

Throttle script request incidents to one per user.

BUG=461979
TEST=NONE

Committed: https://crrev.com/91b055f0066d0d0078a8d241d8f7a26a5c0e0597
Cr-Commit-Position: refs/heads/master@{#318192}

[robertshield, 2015-02-25 21:40:25]

Patchset #1 (id:1) has been deleted

[robertshield, 2015-02-25 21:40:52]

robertshield@chromium.org changed reviewers:
+ grt@chromium.org

[grt (UTC plus 2), 2015-02-26 03:21:37]

this is very close to l-ing-g-t-m.

https://codereview.chromium.org/961483003/diff/20001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/incident_reporting/script_request_incident.cc
(right):

https://codereview.chromium.org/961483003/diff/20001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/incident_reporting/script_request_incident.cc:31:
return "script_request_incident_key";
i prefer simply "script_request_incident" so that the resulting pref dict entry
looks like:
{
  "script_request_incident": 42
}

i think the "_key" suffix will make it look funny, and i wouldn't want the other
preferences to laugh at it.

https://codereview.chromium.org/961483003/diff/20001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/incident_reporting/script_request_incident.cc:35:
// Return a constant to ensure in addition to a fixed key above to ensure that
please reduce the ensure-factor of this comment

[robertshield, 2015-02-26 04:27:53]

https://codereview.chromium.org/961483003/diff/20001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/incident_reporting/script_request_incident.cc
(right):

https://codereview.chromium.org/961483003/diff/20001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/incident_reporting/script_request_incident.cc:31:
return "script_request_incident_key";
On 2015/02/26 03:21:37, grt wrote:
> i prefer simply "script_request_incident" so that the resulting pref dict
entry
> looks like:
> {
>   "script_request_incident": 42
> }
> 
> i think the "_key" suffix will make it look funny, and i wouldn't want the
other
> preferences to laugh at it.

Those other preferences sound like jerks to me.

https://codereview.chromium.org/961483003/diff/20001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/incident_reporting/script_request_incident.cc:35:
// Return a constant to ensure in addition to a fixed key above to ensure that
On 2015/02/26 03:21:37, grt wrote:
> please reduce the ensure-factor of this comment

You can never be too sure.

[grt (UTC plus 2), 2015-02-26 04:47:18]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2015-02-26 04:47:18]

lgtm

https://codereview.chromium.org/961483003/diff/20001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/incident_reporting/script_request_incident.cc
(right):

https://codereview.chromium.org/961483003/diff/20001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/incident_reporting/script_request_incident.cc:31:
return "script_request_incident_key";
On 2015/02/26 04:27:52, robertshield wrote:
> On 2015/02/26 03:21:37, grt wrote:
> > i prefer simply "script_request_incident" so that the resulting pref dict
> entry
> > looks like:
> > {
> >   "script_request_incident": 42
> > }
> > 
> > i think the "_key" suffix will make it look funny, and i wouldn't want the
> other
> > preferences to laugh at it.
> 
> Those other preferences sound like jerks to me.

Their mothers didn't raise them right.

https://codereview.chromium.org/961483003/diff/20001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/incident_reporting/script_request_incident.cc:35:
// Return a constant to ensure in addition to a fixed key above to ensure that
On 2015/02/26 04:27:52, robertshield wrote:
> On 2015/02/26 03:21:37, grt wrote:
> > please reduce the ensure-factor of this comment
> 
> You can never be too sure.

Indubitably.

[commit-bot: I haz the power, 2015-02-26 04:48:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/961483003/40001

[commit-bot: I haz the power, 2015-02-26 05:47:06]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-02-26 05:48:03]

Patchset 2 (id:??) landed as
https://crrev.com/91b055f0066d0d0078a8d241d8f7a26a5c0e0597
Cr-Commit-Position: refs/heads/master@{#318192}