Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 961463002: Minor test fix to block binding (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Minor test fix to block binding The test did not invoke the function BUG=v8:3921 LOG=N R=adamk Committed: https://crrev.com/75a24409829af951734737fa7cf4b0f09386e3a0 Cr-Commit-Position: refs/heads/master@{#26869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M test/mjsunit/harmony/block-scoping.js View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
adamk
Not sure if you meant to send this, but lgtm
5 years, 10 months ago (2015-02-25 23:17:27 UTC) #1
arv (Not doing code reviews)
On 2015/02/25 23:17:27, adamk wrote: > Not sure if you meant to send this, but ...
5 years, 10 months ago (2015-02-25 23:25:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961463002/1
5 years, 10 months ago (2015-02-25 23:26:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 23:27:11 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 23:27:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75a24409829af951734737fa7cf4b0f09386e3a0
Cr-Commit-Position: refs/heads/master@{#26869}

Powered by Google App Engine
This is Rietveld 408576698