editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/correction/MembersSorter.java - Issue 961443004: Issue 21978. Put function 'main' first when sorting members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/correction/MembersSorter.java

Issue 961443004: Issue 21978. Put function 'main' first when sorting members. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine.services_test/src/com/google/dart/engine/services/internal/correction/MembersSorterTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/correction/MembersSorter.java

diff --git a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/correction/MembersSorter.java b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/correction/MembersSorter.java

index c176f1db56735616fd5d2b4aefcad3605a72e15b..c220bdbe3d7d69b742c71cda3fb11ee5f8d9626f 100644

--- a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/correction/MembersSorter.java

+++ b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/correction/MembersSorter.java

@@ -111,6 +111,7 @@ public class MembersSorter {

}

private static enum MemberKind {

+ UNIT_FUNCTION_MAIN,

UNIT_ACCESSOR,

UNIT_FUNCTION,

UNIT_FUNCTION_TYPE,

@@ -151,6 +152,7 @@ public class MembersSorter {

private static final PriorityItem[] PRIORITY_ITEMS = {

// unit

+ new PriorityItem(false, MemberKind.UNIT_FUNCTION_MAIN, false),

new PriorityItem(false, MemberKind.UNIT_VARIABLE, false),

new PriorityItem(false, MemberKind.UNIT_VARIABLE, true),

new PriorityItem(false, MemberKind.UNIT_ACCESSOR, false),

@@ -445,7 +447,11 @@ public class MembersSorter {

kind = MemberKind.UNIT_ACCESSOR;

name += " setter";

} else {

- kind = MemberKind.UNIT_FUNCTION;

+ if (name.equals("main")) {

+ kind = MemberKind.UNIT_FUNCTION_MAIN;

+ } else {

+ kind = MemberKind.UNIT_FUNCTION;

+ }

}

if (member instanceof FunctionTypeAlias) {