components/error_page/renderer/net_error_helper_core.h - Issue 961443002: Three way experiment for "Show saved copy" button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/error_page/renderer/net_error_helper_core.h

Issue 961443002: Three way experiment for "Show saved copy" button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: histograms fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/error_page/renderer/net_error_helper_core.h

diff --git a/components/error_page/renderer/net_error_helper_core.h b/components/error_page/renderer/net_error_helper_core.h

index 4c16e2531f33e7df7ab293853575aa9a7747bf0e..4d880b8d46e72e17baf4e6825c2fe94026034c0a 100644

--- a/components/error_page/renderer/net_error_helper_core.h

+++ b/components/error_page/renderer/net_error_helper_core.h

@@ -45,7 +45,7 @@ class NetErrorHelperCore {

enum Button {

NO_BUTTON,

RELOAD_BUTTON,

- LOAD_STALE_BUTTON,

+ SHOW_SAVED_COPY_BUTTON,

MORE_BUTTON,

};

@@ -59,7 +59,7 @@ class NetErrorHelperCore {

bool is_failed_post,

scoped_ptr<error_page::ErrorPageParams> params,

bool* reload_button_shown,

- bool* load_stale_button_shown,

+ bool* show_saved_copy_button_shown,

std::string* html) const = 0;

// Loads the given HTML in the main frame for use as an error page.