Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3551)

Unified Diff: chrome/renderer/resources/neterror.js

Issue 961443002: Three way experiment for "Show saved copy" button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: histograms fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/neterror.html ('k') | components/error_page/common/net_error_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/neterror.js
diff --git a/chrome/renderer/resources/neterror.js b/chrome/renderer/resources/neterror.js
index cee640f7a0a65a4610e34811bca6318e95535cb3..043a79087c48ce55ba3738a048aae8d4084529a7 100644
--- a/chrome/renderer/resources/neterror.js
+++ b/chrome/renderer/resources/neterror.js
@@ -102,9 +102,9 @@ function reloadButtonClick(url) {
}
}
-function loadStaleButtonClick() {
+function showSavedCopyButtonClick() {
if (window.errorPageController) {
- errorPageController.loadStaleButtonClick();
+ errorPageController.showSavedCopyButtonClick();
}
}
@@ -123,22 +123,28 @@ function onDocumentLoad() {
var controlButtonDiv = document.getElementById('control-buttons');
var reloadButton = document.getElementById('reload-button');
var detailsButton = document.getElementById('details-button');
- var staleLoadButton = document.getElementById('stale-load-button');
+ var showSavedCopyButton = document.getElementById('show-saved-copy-button');
- var primaryButton = reloadButton;
- var secondaryButton = staleLoadButton;
+ var primaryButton, secondaryButton;
+ if (showSavedCopyButton.primary) {
+ primaryButton = showSavedCopyButton;
+ secondaryButton = reloadButton;
+ } else {
+ primaryButton = reloadButton;
+ secondaryButton = showSavedCopyButton;
+ }
// Sets up the proper button layout for the current platform.
if (primaryControlOnLeft) {
buttons.classList.add('suggested-left');
- controlButtonDiv.insertBefore(primaryButton, secondaryButton);
+ controlButtonDiv.insertBefore(secondaryButton, primaryButton);
} else {
buttons.classList.add('suggested-right');
- controlButtonDiv.insertBefore(secondaryButton, primaryButton);
+ controlButtonDiv.insertBefore(primaryButton, secondaryButton);
}
if (reloadButton.style.display == 'none' &&
- staleLoadButton.style.display == 'none') {
+ showSavedCopyButton.style.display == 'none') {
detailsButton.classList.add('singular');
}
@@ -153,15 +159,16 @@ function onDocumentLoad() {
// Show control buttons.
if (loadTimeData.valueExists('reloadButton') &&
loadTimeData.getValue('reloadButton').msg ||
- loadTimeData.valueExists('staleLoadButton') &&
- loadTimeData.getValue('staleLoadButton').msg) {
+ loadTimeData.valueExists('showSavedCopyButton') &&
+ loadTimeData.getValue('showSavedCopyButton').msg) {
controlButtonDiv.hidden = false;
// Set the secondary button state in the cases of two call to actions.
- // Reload is secondary to stale load.
- if (loadTimeData.valueExists('staleLoadButton') &&
- loadTimeData.getValue('staleLoadButton').msg) {
- reloadButton.classList.add('secondary-button');
+ if (loadTimeData.valueExists('reloadButton') &&
+ loadTimeData.getValue('reloadButton').msg &&
+ loadTimeData.valueExists('showSavedCopyButton') &&
+ loadTimeData.getValue('showSavedCopyButton').msg) {
+ secondaryButton.classList.add('secondary-button');
}
}
« no previous file with comments | « chrome/renderer/resources/neterror.html ('k') | components/error_page/common/net_error_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698