Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6943)

Unified Diff: chrome/common/localized_error.cc

Issue 961443002: Three way experiment for "Show saved copy" button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: histograms fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/localized_error.h ('k') | chrome/renderer/net/net_error_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/localized_error.cc
diff --git a/chrome/common/localized_error.cc b/chrome/common/localized_error.cc
index 5472b778567b20b01b83a26fdb3b89f29467a38d..8ee9b36d8aa5fba64c8a1a001e66ed27851efe84 100644
--- a/chrome/common/localized_error.cc
+++ b/chrome/common/localized_error.cc
@@ -4,6 +4,7 @@
#include "chrome/common/localized_error.h"
+#include "base/command_line.h"
#include "base/i18n/rtl.h"
#include "base/logging.h"
#include "base/strings/string16.h"
@@ -11,6 +12,7 @@
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
+#include "chrome/common/chrome_switches.h"
#include "chrome/grit/chromium_strings.h"
#include "chrome/grit/generated_resources.h"
#include "components/error_page/common/error_page_params.h"
@@ -508,7 +510,7 @@ void LocalizedError::GetStrings(int error_code,
const std::string& error_domain,
const GURL& failed_url,
bool is_post,
- bool show_stale_load_button,
+ bool stale_copy_in_cache,
const std::string& locale,
const std::string& accept_languages,
scoped_ptr<error_page::ErrorPageParams> params,
@@ -688,14 +690,28 @@ void LocalizedError::GetStrings(int error_code,
if (!use_default_suggestions)
return;
- if (show_stale_load_button) {
- base::DictionaryValue* stale_load_button = new base::DictionaryValue;
- stale_load_button->SetString(
- "msg", l10n_util::GetStringUTF16(IDS_ERRORPAGES_BUTTON_LOAD_STALE));
- stale_load_button->SetString(
+ base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
+ const std::string& show_saved_copy_value =
+ command_line->GetSwitchValueASCII(switches::kShowSavedCopy);
+ bool show_saved_copy_primary = (show_saved_copy_value ==
+ switches::kEnableShowSavedCopyPrimary);
+ bool show_saved_copy_secondary = (show_saved_copy_value ==
+ switches::kEnableShowSavedCopySecondary);
+ bool show_saved_copy_visible =
+ (stale_copy_in_cache && !is_post &&
+ (show_saved_copy_primary || show_saved_copy_secondary));
+
+ if (show_saved_copy_visible) {
+ base::DictionaryValue* show_saved_copy_button = new base::DictionaryValue;
+ show_saved_copy_button->SetString(
+ "msg", l10n_util::GetStringUTF16(
+ IDS_ERRORPAGES_BUTTON_SHOW_SAVED_COPY));
+ show_saved_copy_button->SetString(
"title",
- l10n_util::GetStringUTF16(IDS_ERRORPAGES_BUTTON_LOAD_STALE_HELP));
- error_strings->Set("staleLoadButton", stale_load_button);
+ l10n_util::GetStringUTF16(IDS_ERRORPAGES_BUTTON_SHOW_SAVED_COPY_HELP));
+ if (show_saved_copy_primary)
+ show_saved_copy_button->SetString("primary", "true");
+ error_strings->Set("showSavedCopyButton", show_saved_copy_button);
}
#if defined(OS_CHROMEOS)
« no previous file with comments | « chrome/common/localized_error.h ('k') | chrome/renderer/net/net_error_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698