Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: chrome/renderer/resources/neterror.js

Issue 961443002: Three way experiment for "Show saved copy" button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: histograms fix Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/renderer/resources/neterror.html ('k') | components/error_page/common/net_error_info.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 function toggleHelpBox() { 5 function toggleHelpBox() {
6 var helpBoxOuter = document.getElementById('details'); 6 var helpBoxOuter = document.getElementById('details');
7 helpBoxOuter.classList.toggle('hidden'); 7 helpBoxOuter.classList.toggle('hidden');
8 var detailsButton = document.getElementById('details-button'); 8 var detailsButton = document.getElementById('details-button');
9 if (helpBoxOuter.classList.contains('hidden')) 9 if (helpBoxOuter.classList.contains('hidden'))
10 detailsButton.innerText = detailsButton.detailsText; 10 detailsButton.innerText = detailsButton.detailsText;
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 // between implementing these in trunk chromium and implementing them in 95 // between implementing these in trunk chromium and implementing them in
96 // iOS. 96 // iOS.
97 function reloadButtonClick(url) { 97 function reloadButtonClick(url) {
98 if (window.errorPageController) { 98 if (window.errorPageController) {
99 errorPageController.reloadButtonClick(); 99 errorPageController.reloadButtonClick();
100 } else { 100 } else {
101 location = url; 101 location = url;
102 } 102 }
103 } 103 }
104 104
105 function loadStaleButtonClick() { 105 function showSavedCopyButtonClick() {
106 if (window.errorPageController) { 106 if (window.errorPageController) {
107 errorPageController.loadStaleButtonClick(); 107 errorPageController.showSavedCopyButtonClick();
108 } 108 }
109 } 109 }
110 110
111 function detailsButtonClick() { 111 function detailsButtonClick() {
112 if (window.errorPageController) 112 if (window.errorPageController)
113 errorPageController.detailsButtonClick(); 113 errorPageController.detailsButtonClick();
114 } 114 }
115 115
116 var primaryControlOnLeft = true; 116 var primaryControlOnLeft = true;
117 <if expr="is_macosx or is_ios or is_linux or is_android"> 117 <if expr="is_macosx or is_ios or is_linux or is_android">
118 primaryControlOnLeft = false; 118 primaryControlOnLeft = false;
119 </if> 119 </if>
120 120
121 function onDocumentLoad() { 121 function onDocumentLoad() {
122 var buttonsDiv = document.getElementById('buttons'); 122 var buttonsDiv = document.getElementById('buttons');
123 var controlButtonDiv = document.getElementById('control-buttons'); 123 var controlButtonDiv = document.getElementById('control-buttons');
124 var reloadButton = document.getElementById('reload-button'); 124 var reloadButton = document.getElementById('reload-button');
125 var detailsButton = document.getElementById('details-button'); 125 var detailsButton = document.getElementById('details-button');
126 var staleLoadButton = document.getElementById('stale-load-button'); 126 var showSavedCopyButton = document.getElementById('show-saved-copy-button');
127 127
128 var primaryButton = reloadButton; 128 var primaryButton, secondaryButton;
129 var secondaryButton = staleLoadButton; 129 if (showSavedCopyButton.primary) {
130 primaryButton = showSavedCopyButton;
131 secondaryButton = reloadButton;
132 } else {
133 primaryButton = reloadButton;
134 secondaryButton = showSavedCopyButton;
135 }
130 136
131 // Sets up the proper button layout for the current platform. 137 // Sets up the proper button layout for the current platform.
132 if (primaryControlOnLeft) { 138 if (primaryControlOnLeft) {
133 buttons.classList.add('suggested-left'); 139 buttons.classList.add('suggested-left');
134 controlButtonDiv.insertBefore(primaryButton, secondaryButton); 140 controlButtonDiv.insertBefore(secondaryButton, primaryButton);
135 } else { 141 } else {
136 buttons.classList.add('suggested-right'); 142 buttons.classList.add('suggested-right');
137 controlButtonDiv.insertBefore(secondaryButton, primaryButton); 143 controlButtonDiv.insertBefore(primaryButton, secondaryButton);
138 } 144 }
139 145
140 if (reloadButton.style.display == 'none' && 146 if (reloadButton.style.display == 'none' &&
141 staleLoadButton.style.display == 'none') { 147 showSavedCopyButton.style.display == 'none') {
142 detailsButton.classList.add('singular'); 148 detailsButton.classList.add('singular');
143 } 149 }
144 150
145 <if expr="not chromeos"> 151 <if expr="not chromeos">
146 // Hide the details button if there are no details to show. 152 // Hide the details button if there are no details to show.
147 if (loadTimeData.valueExists('summary') && 153 if (loadTimeData.valueExists('summary') &&
148 !loadTimeData.getValue('summary').msg) { 154 !loadTimeData.getValue('summary').msg) {
149 detailsButton.style.display = 'none'; 155 detailsButton.style.display = 'none';
150 } 156 }
151 </if> 157 </if>
152 158
153 // Show control buttons. 159 // Show control buttons.
154 if (loadTimeData.valueExists('reloadButton') && 160 if (loadTimeData.valueExists('reloadButton') &&
155 loadTimeData.getValue('reloadButton').msg || 161 loadTimeData.getValue('reloadButton').msg ||
156 loadTimeData.valueExists('staleLoadButton') && 162 loadTimeData.valueExists('showSavedCopyButton') &&
157 loadTimeData.getValue('staleLoadButton').msg) { 163 loadTimeData.getValue('showSavedCopyButton').msg) {
158 controlButtonDiv.hidden = false; 164 controlButtonDiv.hidden = false;
159 165
160 // Set the secondary button state in the cases of two call to actions. 166 // Set the secondary button state in the cases of two call to actions.
161 // Reload is secondary to stale load. 167 if (loadTimeData.valueExists('reloadButton') &&
162 if (loadTimeData.valueExists('staleLoadButton') && 168 loadTimeData.getValue('reloadButton').msg &&
163 loadTimeData.getValue('staleLoadButton').msg) { 169 loadTimeData.valueExists('showSavedCopyButton') &&
164 reloadButton.classList.add('secondary-button'); 170 loadTimeData.getValue('showSavedCopyButton').msg) {
171 secondaryButton.classList.add('secondary-button');
165 } 172 }
166 } 173 }
167 174
168 // Add a main message paragraph. 175 // Add a main message paragraph.
169 if (loadTimeData.valueExists('primaryParagraph')) { 176 if (loadTimeData.valueExists('primaryParagraph')) {
170 var p = document.querySelector('#main-message p'); 177 var p = document.querySelector('#main-message p');
171 p.innerHTML = loadTimeData.getString('primaryParagraph'); 178 p.innerHTML = loadTimeData.getString('primaryParagraph');
172 p.hidden = false; 179 p.hidden = false;
173 } 180 }
174 } 181 }
175 182
176 document.addEventListener('DOMContentLoaded', onDocumentLoad); 183 document.addEventListener('DOMContentLoaded', onDocumentLoad);
OLDNEW
« no previous file with comments | « chrome/renderer/resources/neterror.html ('k') | components/error_page/common/net_error_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698