Subzero: Clean up the runtime implementation.

src/IceTargetLowering.cpp

 //===- subzero/src/IceTargetLowering.cpp - Basic lowering implementation --===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the skeleton of the TargetLowering class,
 // specifically invoking the appropriate lowering method for a given
 // instruction kind and driving global register allocation.  It also
 // implements the non-deleted instruction iteration in
 // LoweringContext.
 //
 //===----------------------------------------------------------------------===//
 
 #include "llvm/Support/CommandLine.h"
 
 #include "assembler_ia32.h"
 #include "IceCfg.h" // setError()
 #include "IceCfgNode.h"
 #include "IceOperand.h"
 #include "IceRegAlloc.h"
 #include "IceTargetLowering.h"
 #include "IceTargetLoweringX8632.h"
 
 namespace Ice {
 

[Mircea Trofin, 2015/02/28 03:28:57]

(overly-pedantic, but...) if the const values lived in their own module, one
could link just that module without the overhead of the rest of this current
one. Now, I can't really articulate a rationale one would use the symbols but
not the rest of the library - and we can always refactor, I suppose.

[Jim Stichnoth, 2015/02/28 04:44:28]

Thinking about this further - when we add a new target, it may require new
helpers that the old target didn't need, and it may not use all the helpers that
the old target needed.  I suspect that when building pnacl-sz for a target using
-ffunction-sections -fdata-sections, unused static char* variables would be
removed but not statically initialized but subsequently unused IceString
variables would not.

With all that in mind, I think I'll go with the const char* approach instead.

+// Runtime helper function names
+const IceString TargetLowering::H_bitcast_16xi1_i16 = "__Sz_bitcast_16xi1_i16";
+const IceString TargetLowering::H_bitcast_8xi1_i8 = "__Sz_bitcast_8xi1_i8";
+const IceString TargetLowering::H_bitcast_i16_16xi1 = "__Sz_bitcast_i16_16xi1";
+const IceString TargetLowering::H_bitcast_i8_8xi1 = "__Sz_bitcast_i8_8xi1";
+const IceString TargetLowering::H_call_ctpop_i32 = "__popcountsi2";
+const IceString TargetLowering::H_call_ctpop_i64 = "__popcountdi2";
+const IceString TargetLowering::H_call_longjmp = "longjmp";
+const IceString TargetLowering::H_call_memcpy = "memcpy";
+const IceString TargetLowering::H_call_memmove = "memmove";
+const IceString TargetLowering::H_call_memset = "memset";
+const IceString TargetLowering::H_call_read_tp = "__nacl_read_tp";
+const IceString TargetLowering::H_call_setjmp = "setjmp";
+const IceString TargetLowering::H_fptosi_f32_i64 = "__Sz_fptosi_f32_i64";
+const IceString TargetLowering::H_fptosi_f64_i64 = "__Sz_fptosi_f64_i64";
+const IceString TargetLowering::H_fptoui_4xi32_f32 = "__Sz_fptoui_4xi32_f32";
+const IceString TargetLowering::H_fptoui_f32_i32 = "__Sz_fptoui_f32_i32";
+const IceString TargetLowering::H_fptoui_f32_i64 = "__Sz_fptoui_f32_i64";
+const IceString TargetLowering::H_fptoui_f64_i32 = "__Sz_fptoui_f64_i32";
+const IceString TargetLowering::H_fptoui_f64_i64 = "__Sz_fptoui_f64_i64";
+const IceString TargetLowering::H_frem_f32 = "fmodf";
+const IceString TargetLowering::H_frem_f64 = "fmod";
+const IceString TargetLowering::H_sdiv_i64 = "__divdi3";
+const IceString TargetLowering::H_sitofp_i64_f32 = "__Sz_sitofp_i64_f32";
+const IceString TargetLowering::H_sitofp_i64_f64 = "__Sz_sitofp_i64_f64";
+const IceString TargetLowering::H_srem_i64 = "__moddi3";
+const IceString TargetLowering::H_udiv_i64 = "__udivdi3";
+const IceString TargetLowering::H_uitofp_4xi32_4xf32 =
+    "__Sz_uitofp_4xi32_4xf32";
+const IceString TargetLowering::H_uitofp_i32_f32 = "__Sz_uitofp_i32_f32";
+const IceString TargetLowering::H_uitofp_i32_f64 = "__Sz_uitofp_i32_f64";
+const IceString TargetLowering::H_uitofp_i64_f32 = "__Sz_uitofp_i64_f32";
+const IceString TargetLowering::H_uitofp_i64_f64 = "__Sz_uitofp_i64_f64";
+const IceString TargetLowering::H_urem_i64 = "__umoddi3";
+
 namespace {
 
 // TODO(stichnot): Move this machinery into main.cpp.
 namespace cl = llvm::cl;
 cl::opt<bool> DoNopInsertion("nop-insertion", cl::desc("Randomly insert NOPs"),
                              cl::init(false));
 
 cl::opt<int> MaxNopsPerInstruction(
     "max-nops-per-instruction",
     cl::desc("Max number of nops to insert per instruction"), cl::init(1));
@@ skipping 229 matching lines @@
   if (Target == Target_ARM64)
     return std::unique_ptr<TargetDataLowering>(TargetDataARM64::create(Ctx));
 #endif
   llvm_unreachable("Unsupported target");
   return nullptr;
 }
 
 TargetDataLowering::~TargetDataLowering() {}
 
 } // end of namespace Ice