Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 961353002: Regression test for v8:3930. (Closed)

Created:
5 years, 9 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Regression test for v8:3930. R=arv@chromium.org,rossberg@chromium.org BUG=v8:3930 LOG=N Committed: https://crrev.com/48fb3e83c5882e9818bc1e0a035864b465602aca Cr-Commit-Position: refs/heads/master@{#26926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
A test/mjsunit/harmony/regress/regress-3930.js View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Dmitry Lomov (no reviews)
PTAL: missed file - a regression test.
5 years, 9 months ago (2015-02-27 20:43:46 UTC) #1
arv (Not doing code reviews)
LGTM
5 years, 9 months ago (2015-02-27 20:45:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961353002/1
5 years, 9 months ago (2015-02-27 20:53:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 21:21:38 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/48fb3e83c5882e9818bc1e0a035864b465602aca Cr-Commit-Position: refs/heads/master@{#26926}
5 years, 9 months ago (2015-02-27 21:21:53 UTC) #6
Michael Achenbach
The test fails here: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%202/builds/1686
5 years, 9 months ago (2015-02-27 22:13:35 UTC) #7
Michael Achenbach
Also here: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/2738
5 years, 9 months ago (2015-02-27 22:21:09 UTC) #8
Dmitry Lomov (no reviews)
5 years, 9 months ago (2015-02-27 22:24:01 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/965043002/ by dslomov@chromium.org.

The reason for reverting is: Fails on nosnap builds.

Powered by Google App Engine
This is Rietveld 408576698