Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 961323003: Upstream MemoryUma and use it for all activities. (Closed)

Created:
5 years, 9 months ago by Yaron
Modified:
5 years, 9 months ago
Reviewers:
Yusuf, ppi
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@upstreamumasessionstats
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream MemoryUma and use it for all activities. This achieves a couple of goals: 1) Upstreams MemoryUma 2) Pulls it up from ChromeTabbedActivity (internal) to AsyncInitializationActivity. This ensures that other activities (e.g. DocumentActivity) also report memory warnings. 3) Instantiate MemoryUma!! This was broken in https://chrome-internal-review.googlesource.com/161577 so low-memory warnings haven't been reported since M35! :( BUG=428903 Committed: https://crrev.com/66456ff82223652f05f339e4db5cb05df6bf67a6 Cr-Commit-Position: refs/heads/master@{#318696}

Patch Set 1 #

Patch Set 2 : don't init mmemoryuma in ctor #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java View 1 5 chunks +18 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/metrics/MemoryUma.java View 1 2 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Yaron
ppi: you're listed as a histogram owner so FYI that this will make the numbers ...
5 years, 9 months ago (2015-02-27 20:05:45 UTC) #2
Yaron
Err, I need a slight change. mMemoryUma should only be init'd when native is initialized ...
5 years, 9 months ago (2015-02-27 20:09:29 UTC) #3
Yaron
On 2015/02/27 20:09:29, Yaron wrote: > Err, I need a slight change. mMemoryUma should only ...
5 years, 9 months ago (2015-02-27 20:12:21 UTC) #4
Yusuf
lgtm with two nits https://codereview.chromium.org/961323003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java File chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java (right): https://codereview.chromium.org/961323003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java#newcode153 chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java:153: if (mMemoryUma != null) mMemoryUma.onStop(); ...
5 years, 9 months ago (2015-02-27 20:31:13 UTC) #5
Yaron
https://codereview.chromium.org/961323003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java File chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java (right): https://codereview.chromium.org/961323003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java#newcode153 chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java:153: if (mMemoryUma != null) mMemoryUma.onStop(); On 2015/02/27 20:31:13, Yusuf ...
5 years, 9 months ago (2015-03-02 14:48:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961323003/40001
5 years, 9 months ago (2015-03-02 14:49:20 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-02 15:28:32 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 15:29:27 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/66456ff82223652f05f339e4db5cb05df6bf67a6
Cr-Commit-Position: refs/heads/master@{#318696}

Powered by Google App Engine
This is Rietveld 408576698