CpuProfiler: do not calculate positions if it is not necessary (BuildCompareInstruction part).

CpuProfiler: do not calculate positions if it is not necessary (BuildCompareInstruction part).

BUG=452067
LOG=n

[loislo, 2015-02-27 12:37:50]

loislo@chromium.org changed reviewers:
+ alph@chromium.org, svenpanne@chromium.org, yurys@chromium.org

[loislo, 2015-02-27 12:37:50]

PTAL

[loislo, 2015-02-27 13:44:52]

loislo@chromium.org changed reviewers:
+ vegorov@chromium.org

[Vyacheslav Egorov (Google), 2015-02-27 13:50:14]

vegorov@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2015-02-27 13:50:15]

https://codereview.chromium.org/961283002/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/961283002/diff/1/src/hydrogen-instructions.h#...
src/hydrogen-instructions.h:1194: void SetOperandPositions(Zone* zone,
SourcePosition left_pos,
This feels really out of place here, because not all HControlInstruction-s have
2 operands. Some have none, some have 1, etc.

[Sven Panne, 2015-03-12 11:44:59]

What's the status of this CL? Is it obsolete? What about Slava's comment?

[loislo, 2015-03-12 14:28:39]

On 2015/03/12 11:44:59, Sven Panne wrote:
> What's the status of this CL? Is it obsolete? What about Slava's comment?

it needs to be reworked. I'll do this in another patch.