Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 961263002: Remove trailing enum comma, I see arm compile failures due to this (Closed)

Created:
5 years, 9 months ago by ricow1
Modified:
5 years, 9 months ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove trailing enum comma, I see arm compile failures due to this R=yangguo@chromium.org BUG= Committed: https://crrev.com/1f0af25b60082cd73db325258500374fbfa9b65c Cr-Commit-Position: refs/heads/master@{#26923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/serialize.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ricow1
5 years, 9 months ago (2015-02-27 09:50:39 UTC) #1
Yang
On 2015/02/27 09:50:39, ricow1 wrote: Lgtm.
5 years, 9 months ago (2015-02-27 12:20:50 UTC) #2
Michael Achenbach
lgtm
5 years, 9 months ago (2015-02-27 18:12:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961263002/1
5 years, 9 months ago (2015-02-27 18:14:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 18:42:49 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 18:43:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f0af25b60082cd73db325258500374fbfa9b65c
Cr-Commit-Position: refs/heads/master@{#26923}

Powered by Google App Engine
This is Rietveld 408576698