Source/core/html/HTMLMediaElement.cpp - Issue 961243002: Do not reset controls upon removing media element from the DOM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 961243002: Do not reset controls upon removing media element from the DOM. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/media/remove-from-document-config-controls-no-crash.html ('K') | « LayoutTests/media/remove-from-document-config-controls-no-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 40724c9baed9ea85a09f19d4290dd712eaedd73b..9e4a12733fd5475cf49f5b8794729503c8fc3222 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -597,13 +597,12 @@ void HTMLMediaElement::removedFrom(ContainerNode* insertionPoint)

{

WTF_LOG(Media, "HTMLMediaElement::removedFrom(%p, %p)", this, insertionPoint);

+ HTMLElement::removedFrom(insertionPoint);

if (insertionPoint->inActiveDocument()) {

configureMediaControls();

if (m_networkState > NETWORK_EMPTY)

pause();

}

- HTMLElement::removedFrom(insertionPoint);

}

void HTMLMediaElement::attach(const AttachContext& context)