Issue 961173003: QuicConnection no longer owns the debug visitor. No behavior change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 961173003: QuicConnection no longer owns the debug visitor. No behavior change. (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)

Modified:
5 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Cleanup_QUIC_TransmissionInfo_86734009

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

QuicConnection no longer owns the debug visitor. No behavior change. The visitor_ isn't owned by the connection, this makes the debug_visitor_ ownership model the same. Merge internal change: 86801250 R=rch@chromium.org

Patch Set 1 #

Patch Set 2 : Fixed leaky ptr #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -38 lines)			Patch
M	net/quic/quic_client_session.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_client_session.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_connection.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	net/quic/quic_connection.cc	View		25 chunks	+26 lines, -24 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View		4 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

On 2015/02/27 23:46:28, ramant wrote: In chrome, the debug visitor is the QuicConnectionLogger. I think ...

5 years, 9 months ago (2015-02-28 00:28:27 UTC) #2

ramant (doing other things)

Many thanks Ryan. Fixed QuicClientSession to use a scoped_ptr. PTAL.

5 years, 9 months ago (2015-02-28 00:43:20 UTC) #3

lgtm

Expand Messages | Collapse Messages