Issue 961103002: Clang warnings for SkFontHost_FreeType_common.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 961103002: Clang warnings for SkFontHost_FreeType_common.cpp (Closed)

Created:
5 years, 9 months ago by f(malita)

Modified:
5 years, 9 months ago

Reviewers:
bungeman-skia, joshua.litt

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Clang warnings for SkFontHost_FreeType_common.cpp Signed/unsigned comparison warnings while attempting to build with Clang on Linux. R=bungeman@google.com,joshualitt@chromium.org Committed: https://skia.googlesource.com/skia/+/cf808aa862b03064619a153a51519c8f0a75b825

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/ports/SkFontHost_FreeType_common.cpp	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961103002/1

5 years, 9 months ago (2015-02-27 16:07:21 UTC) #3

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

5 years, 9 months ago (2015-02-27 16:07:23 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-02-27 16:46:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cf808aa862b03064619a153a51519c8f0a75b825