Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 961083002: Make x86-32 assembly compatible with LLVM's integrated assembler (Closed)

Created:
5 years, 10 months ago by Derek Schuff
Modified:
5 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/nacl-newlib.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make x86-32 assembly compatible with LLVM's integrated assembler The NaCl-specific assembly code was originally written/modified for x86-nacl binutils. This CL makes it also compatible with LLVM's assembler. * Don't rely on the special symbol NACLENTRYALIGN; instead use a #define * Disambiguate a couple of instructions using operand size suffixes. It's not actually necessary to build x86-32 target libraries using LLVM's assembler, but it's nice to have, and LLVM's assembler generates better code in a few cases. R=jvoung@chromium.org BUG=None Committed: https://git.chromium.org/gitweb?p=native_client/nacl-newlib.git;a=commit;h=3c481fd19efa9fd05be99ab71d57f37391122c0c

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M newlib/libc/machine/i386/i386mach.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M newlib/libm/machine/i386/f_ldexp.S View 1 chunk +1 line, -1 line 0 comments Download
M newlib/libm/machine/i386/f_ldexpf.S View 1 chunk +1 line, -1 line 0 comments Download
M newlib/libm/machine/i386/i386mach.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Derek Schuff
5 years, 10 months ago (2015-02-26 22:46:26 UTC) #1
jvoung (off chromium)
otherwise LGTM https://codereview.chromium.org/961083002/diff/1/newlib/libc/machine/i386/i386mach.h File newlib/libc/machine/i386/i386mach.h (right): https://codereview.chromium.org/961083002/diff/1/newlib/libc/machine/i386/i386mach.h#newcode16 newlib/libc/machine/i386/i386mach.h:16: * written to use), but llvm's assembler ...
5 years, 10 months ago (2015-02-26 23:59:14 UTC) #2
Derek Schuff
https://codereview.chromium.org/961083002/diff/1/newlib/libc/machine/i386/i386mach.h File newlib/libc/machine/i386/i386mach.h (right): https://codereview.chromium.org/961083002/diff/1/newlib/libc/machine/i386/i386mach.h#newcode16 newlib/libc/machine/i386/i386mach.h:16: * written to use), but llvm's assembler does not. ...
5 years, 10 months ago (2015-02-27 01:31:38 UTC) #3
Derek Schuff
5 years, 10 months ago (2015-02-27 01:32:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3c481fd19efa9fd05be99ab71d57f37391122c0c (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698