Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 961073004: IDL: Add [LegacyInterfaceTypeChecking] extended attribute (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken, philipj_slow
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Add [LegacyInterfaceTypeChecking] extended attribute This attribute is the opposite of [TypeChecking=Interface], and is intended to replace it in all IDL files. By doing that, we'll explicitly flag attributes and methods with incorrect behavior, instead of having incorrect behavior by default. We should be able to later switch individual attribute and methods over to the correct behavior on a case-by-case basis by dropping the [LegacyInterfaceTypeChecking] attribute from them, and eventually drop support for the attribute altogether. BUG=462561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -14 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/scripts/v8_interface.py View 2 chunks +7 lines, -5 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 3 chunks +6 lines, -5 lines 0 comments Download
M Source/bindings/scripts/v8_utilities.py View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/core/TestInterface.idl View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 4 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Jens Widell
PTAL
5 years, 9 months ago (2015-03-03 07:38:34 UTC) #2
haraken
BTW, how many [LegacyInterfaceTypeChecking] will we need to add? If it's a thousand, it will ...
5 years, 9 months ago (2015-03-03 08:25:31 UTC) #3
Jens Widell
On 2015/03/03 08:25:31, haraken wrote: > BTW, how many [LegacyInterfaceTypeChecking] will we need to add? ...
5 years, 9 months ago (2015-03-03 08:31:27 UTC) #4
haraken
On 2015/03/03 08:31:27, Jens Widell wrote: > On 2015/03/03 08:25:31, haraken wrote: > > BTW, ...
5 years, 9 months ago (2015-03-03 08:36:38 UTC) #5
Jens Widell
On 2015/03/03 08:36:38, haraken wrote: > On 2015/03/03 08:31:27, Jens Widell wrote: > > On ...
5 years, 9 months ago (2015-03-03 08:45:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961073004/1
5 years, 9 months ago (2015-03-03 08:46:14 UTC) #8
philipj_slow
LGTM, no more wondering in review if the interface needs more type checking. This will ...
5 years, 9 months ago (2015-03-03 09:23:36 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 10:17:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191185

Powered by Google App Engine
This is Rietveld 408576698