More shell cleanup: Move NativeRunner(Factory) to native_runner.h.

More shell cleanup: Move NativeRunner(Factory) to native_runner.h.

(I also want to move the contents of dynamic_service_runner.{h,cc} into
native_runner.{h,cc}, but apparently I have to rectify some issues with
the thunks targets first.)

R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/3f2970c13f1f277aac8973bae41c574d338c1f0c

[qsr, 2015-03-05 14:13:19]

qsr@chromium.org changed reviewers:
+ qsr@chromium.org

[qsr, 2015-03-05 14:13:20]

https://codereview.chromium.org/961053005/diff/1/shell/application_manager/ap...
File shell/application_manager/application_manager.h (right):

https://codereview.chromium.org/961053005/diff/1/shell/application_manager/ap...
shell/application_manager/application_manager.h:178: scoped_ptr<Fetcher>
fetcher);
I though scoped_ptr needed the full implementation available. How it is that you
can just forward declare fetcher now?

[jamesr, 2015-03-05 17:36:13]

lgtm

https://codereview.chromium.org/961053005/diff/1/shell/application_manager/ap...
File shell/application_manager/application_manager.h (right):

https://codereview.chromium.org/961053005/diff/1/shell/application_manager/ap...
shell/application_manager/application_manager.h:178: scoped_ptr<Fetcher>
fetcher);
On 2015/03/05 14:13:19, qsr wrote:
> I though scoped_ptr needed the full implementation available. How it is that
you
> can just forward declare fetcher now?

scoped_ptr<T>::reset() (which is called by ~scoped_ptr<T>) needs the full
definition of T.  Here, the function is out-of-line so reset() is invoked by the
definition of the function, not the declaration. thus the .cc needs to see the
full type of T but not the declaration of the function signature. if this was
inlined then it would need T

[viettrungluu, 2015-03-05 18:22:00]

Committed patchset #2 (id:20001) manually as
3f2970c13f1f277aac8973bae41c574d338c1f0c (presubmit successful).