Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 961033003: Don't check includes in generate_jar_jni target (Closed)

Created:
5 years, 10 months ago by jamesr
Modified:
5 years, 9 months ago
Reviewers:
cjhopman, brettw
CC:
chromium-reviews, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't check includes in generate_jar_jni target 'gn check' for ui/gl:* in an android build currently fails with the error message: ERROR at //base/android/jni_generator/jni_generator_helper.h:11:11: Include not allowed. ^------------------------- It is not in any dependency of //ui/gl:surface_jni_headers__jni_Surface The include file is in the target(s): //base:base which should somehow be reachable from //ui/gl:surface_jni_headers__jni_Surface This target does not produce files that compile, so checking includes is less useful. R=brettw@chromium.org Committed: https://crrev.com/63e12fcc153d47463432954d1826c393c0962600 Cr-Commit-Position: refs/heads/master@{#318983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/config/android/rules.gni View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jamesr
Chris - does this look right? We could also add a dep to this target ...
5 years, 10 months ago (2015-02-26 19:16:43 UTC) #2
jamesr
Or maybe a newer GN will be better at this - let me test that ...
5 years, 10 months ago (2015-02-26 19:23:50 UTC) #3
jamesr
ToT GN still needs this patch.
5 years, 10 months ago (2015-02-26 19:26:24 UTC) #4
cjhopman
lgtm
5 years, 9 months ago (2015-02-27 23:05:55 UTC) #5
brettw
lgtm
5 years, 9 months ago (2015-02-28 00:18:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961033003/1
5 years, 9 months ago (2015-03-04 00:21:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 00:51:42 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:52:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63e12fcc153d47463432954d1826c393c0962600
Cr-Commit-Position: refs/heads/master@{#318983}

Powered by Google App Engine
This is Rietveld 408576698