Issue 96103002: [Mac] Workaround for Mavericks AppKit accessibility bug in NSCollectionView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 96103002: [Mac] Workaround for Mavericks AppKit accessibility bug in NSCollectionView. (Closed)

Created:
7 years ago by tapted

Modified:
7 years ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Mac] Workaround for Mavericks AppKit accessibility bug in NSCollectionView. Using the accessibility inspector on the Mac App Launcher in Mavericks currently causes Chrome to crash. This is due to an AppKit bug that triggers an unrecognized selector exception to be thrown on -[NSButtonCell item], inside NSCollectionView code. This adds a method to the NSButtonCell subclass used by the app launcher for its NSCollectionView that provides a dummy implementation of the method AppKit tries to call. BUG=324365 TEST=Open Mac's Accessibility Inspector, then show the App Launcher. Hovering over items in the grid should not crash Chrome. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238249