Chromium Code Reviews

Issue 961003002: Invalidate the global property cell when converting from data to accessor. (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Invalidate the global property cell when converting from data to accessor. BUG= TBR=jkummerow@chromium.org, Committed: https://crrev.com/6a12dc240b1faffa500ff269077d832ecc74239d Cr-Commit-Position: refs/heads/master@{#26896}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+26 lines, -8 lines)
M src/ic/handler-compiler.h View 1 chunk +1 line, -1 line 0 comments
M src/objects.cc View 2 chunks +10 lines, -7 lines 0 comments
A test/mjsunit/regress/convert-global-data-to-accessor.js View 1 chunk +15 lines, -0 lines 0 comments

Messages

Total messages: 8 (2 generated)
Toon Verwaest
PTAL TBR=jkummerow@chromium.org,
5 years, 10 months ago (2015-02-26 18:27:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961003002/1
5 years, 10 months ago (2015-02-26 18:28:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 18:48:57 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6a12dc240b1faffa500ff269077d832ecc74239d Cr-Commit-Position: refs/heads/master@{#26896}
5 years, 10 months ago (2015-02-26 18:49:09 UTC) #6
Jakob Kummerow
LGTM.
5 years, 10 months ago (2015-02-26 19:21:00 UTC) #7
Michael Achenbach
5 years, 10 months ago (2015-02-26 21:01:47 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/958113004/ by machenbach@chromium.org.

The reason for reverting is: Breaks gc stress, e.g.:
http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%201/build....

Powered by Google App Engine