Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Issue 960963003: [NaCl SDK] Consistently honor LDFLAGS in SDK build system (Closed)

Created:
5 years, 10 months ago by Sam Clegg
Modified:
5 years, 9 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Consistently honor LDFLAGS in SDK build system host_gcc.mk was already honoring this variable, as was the SO_RULE in nacl_gcc.mk but the LINK_RULE for nacl_gcc.mk and nacl_llvm.mk was ignoring LDFLAGS. Committed: https://crrev.com/aad9f37acd056092bf0ee579c328ed024ef41609 Cr-Commit-Position: refs/heads/master@{#318586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M native_client_sdk/src/tools/nacl_gcc.mk View 3 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/tools/nacl_llvm.mk View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Sam Clegg
5 years, 10 months ago (2015-02-27 00:31:18 UTC) #2
binji
lgtm
5 years, 10 months ago (2015-02-27 00:34:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960963003/1
5 years, 9 months ago (2015-02-28 01:25:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-28 03:09:16 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 03:10:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aad9f37acd056092bf0ee579c328ed024ef41609
Cr-Commit-Position: refs/heads/master@{#318586}

Powered by Google App Engine
This is Rietveld 408576698