Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2967)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java

Issue 960923004: Add two instrumentation tests for Web Notifications on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java
index 60d8f135ee5418552588ac337c4e75a5db61d821..1e1c1f7c88f5e886036380a2daa17217b5c23e3d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java
@@ -13,6 +13,9 @@ import android.app.Notification;
* @see http://developer.android.com/reference/android/app/NotificationManager.html
*/
public interface NotificationManagerProxy {
- void cancel(int id);
- void notify(int id, Notification notification);
+ public void cancel(int id);
Michael van Ouwerkerk 2015/02/26 17:24:23 nit: Java interface methods are public by default,
Peter Beverloo 2015/02/26 18:22:38 Yup, but I like them because they make this explic
+ public void cancel(String tag, int id);
+ public void cancelAll();
+ public void notify(int id, Notification notification);
+ public void notify(String tag, int id, Notification notification);
}

Powered by Google App Engine
This is Rietveld 408576698