Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 960913003: [Android] Measure AppMenu animation jankiness by frame times UMA. (Closed)

Created:
5 years, 9 months ago by Kibeom Kim (inactive)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Measure AppMenu animation jankiness by frame times UMA. AppMenu animation is known to be very janky on some low-end devices. It will be helpful to indentify what devices are having this issue through UMA. TBR=isherman@chromium.org BUG=461066 Committed: https://crrev.com/6433ae0672faa8cf9b04dcc7b603412180552dbb Cr-Commit-Position: refs/heads/master@{#318778}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : cancel animation on dismiss #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 1 2 7 chunks +13 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960913003/1
5 years, 9 months ago (2015-02-27 22:41:17 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/6935)
5 years, 9 months ago (2015-02-28 04:35:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960913003/1
5 years, 9 months ago (2015-02-28 05:24:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/7087)
5 years, 9 months ago (2015-02-28 11:50:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960913003/20001
5 years, 9 months ago (2015-03-02 19:07:26 UTC) #12
Kibeom Kim (inactive)
ptal dtrainor@
5 years, 9 months ago (2015-03-02 21:02:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960913003/40001
5 years, 9 months ago (2015-03-02 21:03:53 UTC) #15
David Trainor- moved to gerrit
lgtm
5 years, 9 months ago (2015-03-02 22:13:28 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-02 22:36:36 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6433ae0672faa8cf9b04dcc7b603412180552dbb Cr-Commit-Position: refs/heads/master@{#318778}
5 years, 9 months ago (2015-03-02 22:37:46 UTC) #18
Ilya Sherman
histograms.xml lgtm, but why did you TBR this?
5 years, 9 months ago (2015-03-03 00:00:59 UTC) #19
Kibeom Kim (inactive)
5 years, 9 months ago (2015-03-03 00:04:03 UTC) #20
Message was sent while issue was closed.
Oh, sorry for not mentioning, histograms.xml was once lgtmed here
https://codereview.chromium.org/949613002/#ps190001 I just split the CL.

Powered by Google App Engine
This is Rietveld 408576698