Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 9609008: Implemented Browser Plugin (NOT FOR REVIEW) (Closed)

Created:
8 years, 9 months ago by Fady Samuel
Modified:
8 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, apatrick_chromium, brettw-cc_chromium.org, brettw, darin (slow to review), rjkroege, Erik does not do reviews, piman
Visibility:
Public.

Description

Implemented Browser Plugin (NOT FOR REVIEW) Need this patch to compile. https://bugs.webkit.org/show_bug.cgi?id=85916 BUG=117897 TEST=manually

Patch Set 1 #

Patch Set 2 : Removed some unnecessary changes #

Patch Set 3 : Updated to use PpapiCommandBufferProxy instead of GuestToHostCommandBuffer => More code reuse! #

Patch Set 4 : Removed unnecessary call to WebView that required a WebKit change #

Patch Set 5 : Added support for src attribute. Need to fix setting of width/height. #

Patch Set 6 : i #

Patch Set 7 : Removed unnecessary change in ChromeContentClient #

Patch Set 8 : Removed unnecessary dependency on WebKit change. Thanks jamesr! #

Patch Set 9 : Use filtered input #

Patch Set 10 : Clean-up of GuestRenderViewObserver and GuestRenderViewHostObserver #

Patch Set 11 : Guests can now recover from lost contexts! (most of the time) #

Patch Set 12 : Merged with Tip-of-Tree #

Patch Set 13 : Updated to merge with Tip-of-Tree and removed the last chrome dependency #

Patch Set 14 : Initial plumbing of a guest flag to RenderViewImpl (cleaner than early prototype) #

Patch Set 15 : No guest flag for now #

Patch Set 16 : Merge with ToT and moved browser plugin specific files to browser_plugin directories #

Patch Set 17 : Failed Attempt at Implementing Browser Plugin Guest with Two GPU Channels #

Patch Set 18 : Mostly working implementation of browser plugin without playDead and delayed WebGraphicsContext3D i… #

Patch Set 19 : Cleanup. Reattempt at context loss recovery #

Patch Set 20 : Removed WebGraphicsContext3DGuest's dependency on other parts of browser plugin (for independent re… #

Patch Set 21 : Merged with Tip-of-Tree after landing guest plumbing #

Patch Set 22 : Merge with ToT #

Patch Set 23 : Beginnings of cleaning up guests on host navigation/dead/tab close #

Patch Set 24 : Lost Context Recovery Works Again! #

Patch Set 25 : PpapiCommandBufferProxy now implements CommandBufferProxy #

Patch Set 26 : Suspend Guests If Host Is Hidden #

Patch Set 27 : Better, less hacky, guest sizing #

Patch Set 28 : Merge with ToT and temporary hack to fix resize. #

Patch Set 29 : Merge with ToT after landing WGC3DCmdBufferImpl refactor #

Patch Set 30 : Removed Unnecessary BrowserPluginMessageFilter #

Patch Set 31 : Removed GuestRenderViewHostObserver #

Patch Set 32 : A little bit of cleanup #

Patch Set 33 : WebGraphicsContext3DGuest no longer necessary! Thanks piman@! #

Patch Set 34 : Removed RenderWidget change. Added new GuestReady message #

Patch Set 35 : Lots of cleanup according to jam@ and piman@ #

Patch Set 36 : Removed WebGraphicsContext3DDelegate #

Patch Set 37 : Merge with ToT after landing some patches #

Patch Set 38 : Removed unnecessary change #

Patch Set 39 : One GuestToHostChannel per Guest-Host pair. Towards decoupling guest RenderView from BrowserPlugin … #

Patch Set 40 : Renamed classes to better represent their function. Merged with ToT. #

Patch Set 41 : Towards cross-process navigation + clean-up #

Patch Set 42 : First attempt at cross-process navigation works! #

Patch Set 43 : Lots of cleanup and simplification BrowserPluginMessageFilter is once again gone. #

Patch Set 44 : Fixed a broken build on some compilers #

Patch Set 45 : Updated according to discussion with fishd@ #

Patch Set 46 : Crashed embedder should not crash the browser on reload #

Patch Set 47 : Browser Plugin is no longer a WebViewPlugin::Delegate. Need to figure out lifetime of BrowserPlugin #

Patch Set 48 : Receives navigation message on HandleMessage and navigates across processes! #

Patch Set 49 : Merge with ToT #

Patch Set 50 : Merge with ToT. GuestToEmbedderChannel is now Dispatcher. #

Patch Set 51 : No need to pass embedder_routing_id to renderer #

Patch Set 52 : Renderer no longer needs to know about embedder_process_id #

Patch Set 53 : Fixed an occasional DCHECK on cross-process navigation #

Patch Set 54 : New BrowserPluginSerializationRules. Removed unnecessary changes to VarTracker #

Patch Set 55 : Merge with ToT + pending patch #

Patch Set 56 : Relative to pending patch #

Patch Set 57 : Better diff: Removed unnecessary changes #

Patch Set 58 : More cleanup #

Patch Set 59 : Further cleanup #

Patch Set 60 : Further cleanup #

Patch Set 61 : Updated according to creis@'s comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1640 lines, -291 lines) Patch
A content/browser/browser_plugin/browser_plugin_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 1 chunk +114 lines, -0 lines 0 comments Download
A content/browser/browser_plugin/browser_plugin_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 1 chunk +228 lines, -0 lines 0 comments Download
A content/browser/browser_plugin/example.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +40 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 3 chunks +11 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 4 chunks +11 lines, -1 line 0 comments Download
M content/common/browser_plugin_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 56 57 58 60 2 chunks +39 lines, -23 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 56 57 58 60 1 chunk +10 lines, -2 lines 0 comments Download
A content/renderer/browser_plugin/browser_plugin.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 1 chunk +91 lines, -0 lines 0 comments Download
A content/renderer/browser_plugin/browser_plugin.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 1 chunk +167 lines, -0 lines 0 comments Download
A content/renderer/browser_plugin/browser_plugin_channel_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 1 chunk +73 lines, -0 lines 0 comments Download
A content/renderer/browser_plugin/browser_plugin_channel_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 1 chunk +122 lines, -0 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_placeholder.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 56 57 58 60 1 chunk +0 lines, -89 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_placeholder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 56 57 58 60 1 chunk +0 lines, -143 lines 0 comments Download
A content/renderer/browser_plugin/browser_plugin_registry.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 1 chunk +36 lines, -0 lines 0 comments Download
A content/renderer/browser_plugin/browser_plugin_registry.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 56 57 58 60 1 chunk +39 lines, -0 lines 0 comments Download
A content/renderer/browser_plugin/browser_plugin_var_serialization_rules.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 56 57 58 60 1 chunk +34 lines, -0 lines 0 comments Download
A content/renderer/browser_plugin/browser_plugin_var_serialization_rules.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 56 57 58 60 1 chunk +51 lines, -0 lines 0 comments Download
A content/renderer/browser_plugin/guest_to_embedder_channel.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 1 chunk +125 lines, -0 lines 0 comments Download
A content/renderer/browser_plugin/guest_to_embedder_channel.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 1 chunk +276 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 56 57 58 60 1 chunk +7 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 56 57 58 60 2 chunks +36 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 56 57 58 60 4 chunks +13 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 56 57 58 60 3 chunks +27 lines, -16 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 56 57 58 60 6 chunks +39 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 12 chunks +49 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Fady Samuel
Uploaded for early feedback.
8 years, 9 months ago (2012-03-06 18:15:13 UTC) #1
Fady Samuel
Hi all, This is not quite for review yet, but more of an FYI. I've ...
8 years, 9 months ago (2012-03-14 18:00:57 UTC) #2
brettw
8 years, 9 months ago (2012-03-14 22:59:20 UTC) #3
I don't really have time to follow everybody's progress. If you're ready for
review or you have specific questions, please ask. But otherwise you can save
yourself some time and not send mail when you upload partial patches.

Powered by Google App Engine
This is Rietveld 408576698