Match profile name textfield behaviour to Windows

Match profile name textfield behaviour to Windows

- Submit on tab
- Do nothing when field is empty

BUG=457585
Committed: https://crrev.com/270228dcf53f3da72c2ceaf1529d5c8353d88294
Cr-Commit-Position: refs/heads/master@{#318945}

[wesleylancel, 2015-02-26 11:16:14]

wesleylancel@gmail.com changed reviewers:
+ groby@chromium.org

[groby-ooo-7-16, 2015-02-27 23:32:38]

https://codereview.chromium.org/960863002/diff/1/chrome/browser/ui/cocoa/prof...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/960863002/diff/1/chrome/browser/ui/cocoa/prof...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:732: // Somehow
this doesn't work if it's not async. Might need improving.
I don't think I'm OK with code that is based on "somehow" :)

I would _think_ what happens here is that controlTextDidEndEditing: is executed
in the same iteration of the message loop as advancing the first responder as a
result of controlTextDidEndEditing.

In that case, the comment should call this out. At the very least, we should
figure out why it needs to be async.

[wesleylancel, 2015-02-27 23:50:50]

On 2015/02/27 23:32:38, groby wrote:
>
https://codereview.chromium.org/960863002/diff/1/chrome/browser/ui/cocoa/prof...
> File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):
> 
>
https://codereview.chromium.org/960863002/diff/1/chrome/browser/ui/cocoa/prof...
> chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:732: // Somehow
> this doesn't work if it's not async. Might need improving.
> I don't think I'm OK with code that is based on "somehow" :)
> 
> I would _think_ what happens here is that controlTextDidEndEditing: is
executed
> in the same iteration of the message loop as advancing the first responder as
a
> result of controlTextDidEndEditing.
> 
> In that case, the comment should call this out. At the very least, we should
> figure out why it needs to be async.

Yeah, I agree. I posted it here hoping you would have experience with a similar
thing.

I actually found this solution on StackOverflow after doing some research. I was
unable to find anything in the docs.

How would you recommend I go about confirming this?

[wesleylancel, 2015-02-28 00:02:32]

On 2015/02/27 23:50:50, wesleylancel wrote:
> On 2015/02/27 23:32:38, groby wrote:
> >
>
https://codereview.chromium.org/960863002/diff/1/chrome/browser/ui/cocoa/prof...
> > File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):
> > 
> >
>
https://codereview.chromium.org/960863002/diff/1/chrome/browser/ui/cocoa/prof...
> > chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:732: //
Somehow
> > this doesn't work if it's not async. Might need improving.
> > I don't think I'm OK with code that is based on "somehow" :)
> > 
> > I would _think_ what happens here is that controlTextDidEndEditing: is
> executed
> > in the same iteration of the message loop as advancing the first responder
as
> a
> > result of controlTextDidEndEditing.
> > 
> > In that case, the comment should call this out. At the very least, we should
> > figure out why it needs to be async.
> 
> Yeah, I agree. I posted it here hoping you would have experience with a
similar
> thing.
> 
> I actually found this solution on StackOverflow after doing some research. I
was
> unable to find anything in the docs.
> 
> How would you recommend I go about confirming this?

By the way, the main issue was that it was keeping focus if I didn't change the
text or left it empty. I think the built-in behaviour is that focus is reset to
the field if one of those two scenarios is true. I can't find anything about
this anywhere though. It's possible that that happens in the same iteration
though.

[groby-ooo-7-16, 2015-02-28 01:02:44]

You can probably confirm by getting the callstack at the window's
-becomeFirstResponder. If this doesn't work synchronously, something does reset
first responder status. You want to catch it in the act. 

Alternatively, leave a link here saying "according to SO". I'm fine with that, I
just want the next person looking here able to figure out why we do this.

[groby-ooo-7-16, 2015-02-28 01:03:00]

(So, really, if you change the comment, LGTM w/ nits)

[wesleylancel, 2015-03-03 20:49:52]

The CQ bit was checked by wesleylancel@gmail.com

[wesleylancel, 2015-03-03 20:49:53]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org
Link to the patchset: https://codereview.chromium.org/960863002/#ps20001 (title:
"Rephrase comment")

[wesleylancel, 2015-03-03 20:50:08]

On 2015/02/28 01:03:00, groby wrote:
> (So, really, if you change the comment, LGTM w/ nits)

Done.

[commit-bot: I haz the power, 2015-03-03 20:50:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960863002/20001

[commit-bot: I haz the power, 2015-03-03 21:45:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-03 21:45:57]

Patchset 2 (id:??) landed as
https://crrev.com/270228dcf53f3da72c2ceaf1529d5c8353d88294
Cr-Commit-Position: refs/heads/master@{#318945}