src/base/platform/platform-win32.cc - Issue 960813004: Fix preparing log file name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/base/platform/platform-win32.cc

Issue 960813004: Fix preparing log file name. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/base/platform/platform-win32.cc

diff --git a/src/base/platform/platform-win32.cc b/src/base/platform/platform-win32.cc

index 5a6f2f1cbfcfab31ecc8b9d7768b9348fae6e806..177be26cc8fca18b0885a718d501fcb989055537 100644

--- a/src/base/platform/platform-win32.cc

+++ b/src/base/platform/platform-win32.cc

@@ -575,6 +575,11 @@ bool OS::Remove(const char* path) {

}

+bool OS::isDirectorySeparator(const char ch) {

+ return (ch == '/' || ch == '\\');

Yang 2015/03/03 08:36:57 brackets unnecessary.

sejunho 2015/03/03 10:14:50 Done.

FILE* OS::OpenTemporaryFile() {

// tmpfile_s tries to use the root dir, don't use it.

char tempPathBuffer[MAX_PATH];