Fix preparing log file name.

Fix preparing log file name.

Problem:
Excuting with flags as "--prof --logfile-per-isolate --logfile=/path/to/filename"
expected file name: /path/to/isolate-<isolate id>-filename
current result: isolate-<isolate id>-/path/to/filename

This patch makes the file name we expected.

Committed: https://crrev.com/a6f5fca5e631b6600bd1b6efd9f2d899c1a0d023
Cr-Commit-Position: refs/heads/master@{#26955}

[sejunho, 2015-03-03 05:45:16]

sejunho@gmail.com changed reviewers:
+ yangguo@chromium.org

[sejunho, 2015-03-03 05:46:18]

Hello, please take a look :)

[Yang, 2015-03-03 08:36:58]

Some comments.

Honestly I think the better solution, and more flexible too, is to introduce %i
that expands to the isolate id. Then we could remove --logfile-per-isolate.

https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-p...
File src/base/platform/platform-posix.cc (right):

https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-p...
src/base/platform/platform-posix.cc:360: return (ch == '/');
brackets unnecessary.

https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-w...
File src/base/platform/platform-win32.cc (right):

https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-w...
src/base/platform/platform-win32.cc:579: return (ch == '/' || ch == '\\');
brackets unnecessary.

https://codereview.chromium.org/960813004/diff/1/src/log.cc
File src/log.cc (right):

https://codereview.chromium.org/960813004/diff/1/src/log.cc#newcode1773
src/log.cc:1773: slash_count++;
no line break after if.

https://codereview.chromium.org/960813004/diff/1/src/log.cc#newcode1785
src/log.cc:1785: } else if (*p == '%') {
How about

if (*p == '%') {
  ... 
} else {
  if (base::OS::isDirectorySeparator(*p)) slash_count--;
  os << *p;
}

[sejunho, 2015-03-03 10:14:51]

https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-p...
File src/base/platform/platform-posix.cc (right):

https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-p...
src/base/platform/platform-posix.cc:360: return (ch == '/');
On 2015/03/03 08:36:57, Yang wrote:
> brackets unnecessary.

Done.

https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-w...
File src/base/platform/platform-win32.cc (right):

https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-w...
src/base/platform/platform-win32.cc:579: return (ch == '/' || ch == '\\');
On 2015/03/03 08:36:57, Yang wrote:
> brackets unnecessary.

Done.

https://codereview.chromium.org/960813004/diff/1/src/log.cc
File src/log.cc (right):

https://codereview.chromium.org/960813004/diff/1/src/log.cc#newcode1773
src/log.cc:1773: slash_count++;
On 2015/03/03 08:36:57, Yang wrote:
> no line break after if.

Done.

https://codereview.chromium.org/960813004/diff/1/src/log.cc#newcode1785
src/log.cc:1785: } else if (*p == '%') {
On 2015/03/03 08:36:57, Yang wrote:
> How about
> 
> if (*p == '%') {
>   ... 
> } else {
>   if (base::OS::isDirectorySeparator(*p)) slash_count--;
>   os << *p;
> }

OK.

[Yang, 2015-03-03 10:22:43]

On 2015/03/03 10:14:51, sejunho wrote:
>
https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-p...
> File src/base/platform/platform-posix.cc (right):
> 
>
https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-p...
> src/base/platform/platform-posix.cc:360: return (ch == '/');
> On 2015/03/03 08:36:57, Yang wrote:
> > brackets unnecessary.
> 
> Done.
> 
>
https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-w...
> File src/base/platform/platform-win32.cc (right):
> 
>
https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-w...
> src/base/platform/platform-win32.cc:579: return (ch == '/' || ch == '\\');
> On 2015/03/03 08:36:57, Yang wrote:
> > brackets unnecessary.
> 
> Done.
> 
> https://codereview.chromium.org/960813004/diff/1/src/log.cc
> File src/log.cc (right):
> 
> https://codereview.chromium.org/960813004/diff/1/src/log.cc#newcode1773
> src/log.cc:1773: slash_count++;
> On 2015/03/03 08:36:57, Yang wrote:
> > no line break after if.
> 
> Done.
> 
> https://codereview.chromium.org/960813004/diff/1/src/log.cc#newcode1785
> src/log.cc:1785: } else if (*p == '%') {
> On 2015/03/03 08:36:57, Yang wrote:
> > How about
> > 
> > if (*p == '%') {
> >   ... 
> > } else {
> >   if (base::OS::isDirectorySeparator(*p)) slash_count--;
> >   os << *p;
> > }
> 
> OK.

WDYT about the suggestion of introducing %i?

[sejunho, 2015-03-03 10:26:41]

On 2015/03/03 08:36:58, Yang wrote:
> Honestly I think the better solution, and more flexible too, is to introduce
%i
> that expands to the isolate id. Then we could remove --logfile-per-isolate.

I think introducing %i needs announcement to users.
This link is one of the best document about profiling, but there are just
only one expansion(%p). 
http://www.chromium.org/developers/creating-v8-profiling-timeline-plots

[Yang, 2015-03-03 10:30:16]

On 2015/03/03 10:26:41, sejunho wrote:
> On 2015/03/03 08:36:58, Yang wrote:
> > Honestly I think the better solution, and more flexible too, is to introduce
> %i
> > that expands to the isolate id. Then we could remove --logfile-per-isolate.
> 
> I think introducing %i needs announcement to users.
> This link is one of the best document about profiling, but there are just
> only one expansion(%p). 
> http://www.chromium.org/developers/creating-v8-profiling-timeline-plots

lgtm. Please use the commit checkbox to commit.

[sejunho, 2015-03-03 10:33:08]

The CQ bit was checked by sejunho@gmail.com

[commit-bot: I haz the power, 2015-03-03 10:34:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960813004/40001

[commit-bot: I haz the power, 2015-03-03 11:03:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-03 11:03:57]

Patchset 3 (id:??) landed as
https://crrev.com/a6f5fca5e631b6600bd1b6efd9f2d899c1a0d023
Cr-Commit-Position: refs/heads/master@{#26955}

[sejunho, 2015-05-27 05:33:15]

Patchset #4 (id:60001) has been deleted