Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 960793003: Allow lookup of module exports by export name. (Closed)

Created:
5 years, 10 months ago by adamk
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow lookup of module exports by export name. This required fixing the exports_ hash map to use the appropriate comparison function instead of pointer comparison. BUG=v8:1569 LOG=n Committed: https://crrev.com/a7840a2b3ea2db8b8bd3b80311334dbe39256ebc Cr-Commit-Position: refs/heads/master@{#26920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M src/modules.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/modules.cc View 2 chunks +15 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
5 years, 10 months ago (2015-02-27 00:33:59 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 10 months ago (2015-02-27 02:59:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960793003/1
5 years, 9 months ago (2015-02-27 17:25:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 18:04:53 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 18:05:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7840a2b3ea2db8b8bd3b80311334dbe39256ebc
Cr-Commit-Position: refs/heads/master@{#26920}

Powered by Google App Engine
This is Rietveld 408576698