Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 960783002: [turbofan] Fix bogus covering of Word64Equal w/ zero. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix bogus covering of Word64Equal w/ zero. Committed: https://crrev.com/0f783c676bda644dc388f6f5d87d27bae91d2848 Cr-Commit-Position: refs/heads/master@{#26870}

Patch Set 1 #

Patch Set 2 : [arm64] Fix unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -78 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +6 lines, -19 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +6 lines, -19 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 2 chunks +0 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-26 06:50:57 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-26 07:16:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960783002/20001
5 years, 10 months ago (2015-02-26 07:17:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 07:18:31 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 07:18:51 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f783c676bda644dc388f6f5d87d27bae91d2848
Cr-Commit-Position: refs/heads/master@{#26870}

Powered by Google App Engine
This is Rietveld 408576698