Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 960773007: Make the auto-pusher recover easier. (Closed)

Created:
5 years, 9 months ago by Michael Achenbach
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make the auto-pusher recover easier. The auto-push script is only used in an automated fashion on bots. It doesn't need to check for a clean git environment as it has a special workdir checkout. If the release creation fails for whatever reason (e.g. a master restart happens in the middle), the workdir checkout might be left dirty. Any new attempt of the auto pusher then bails out. After this change it will call the create_release script in any case which tidies up the workspace on startup. TBR=tandrii@chromium.org NOTRY=true TEST=./script_test.py Committed: https://crrev.com/002b1ddb0e1aa5172b644f9d9b29caa05e830650 Cr-Commit-Position: refs/heads/master@{#26928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M tools/release/auto_push.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/release/test_scripts.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 9 months ago (2015-02-27 15:13:31 UTC) #2
tandrii(chromium)
lgtm
5 years, 9 months ago (2015-02-27 16:32:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960773007/1
5 years, 9 months ago (2015-02-27 22:23:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 22:23:31 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 22:23:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/002b1ddb0e1aa5172b644f9d9b29caa05e830650
Cr-Commit-Position: refs/heads/master@{#26928}

Powered by Google App Engine
This is Rietveld 408576698