src/core/Sk4x.h - Issue 960773005: Think implicit promotion is a good idea?

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/Sk4x.h

Issue 960773005: Think implicit promotion is a good idea? (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/Sk4x.h

diff --git a/src/core/Sk4x.h b/src/core/Sk4x.h

index 7c246dffc01b7265c44772f2328f0ad385adba1c..058c40038037f0516efae2ccc8dfead9bb749ef4 100644

--- a/src/core/Sk4x.h

+++ b/src/core/Sk4x.h

@@ -22,7 +22,8 @@ typedef Sk4x<int32_t> Sk4i;

template <typename T> class Sk4x {

public:

- Sk4x(); // Uninitialized; use Sk4x(0,0,0,0) for zero.

+ Sk4x(); // Uninitialized; use Sk4x(0) for zero.

+ /*implicit*/ Sk4x(T); // Same as Sk4x(T,T,T,T);

Sk4x(T, T, T, T);

Sk4x(const Sk4x&);

« no previous file with comments | « no previous file | src/core/Sk4x_portable.h » ('j') | no next file with comments »