Add a name to the proxy resolver utility process and display it in the task manager.

Add a name to the proxy resolver utility process and display it in the task manager.

BUG=467832
Committed: https://crrev.com/cd95c253cae9d0c2d53cdb1b899fa071906b65e5
Cr-Commit-Position: refs/heads/master@{#321495}

[Anand Mistry (off Chromium), 2015-03-17 06:31:48]

amistry@chromium.org changed reviewers:
+ avi@chromium.org, jhawkins@chromium.org

[Anand Mistry (off Chromium), 2015-03-17 06:31:49]

jhawkins@chromium.org: Please review changes in chrome/

avi@chromium.org: Please review changes in content/

[Avi (use Gerrit), 2015-03-17 14:33:50]

lgtm

OK

[James Hawkins, 2015-03-17 15:24:14]

Can you post a screenshot of the new UI?

https://codereview.chromium.org/960753003/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (left):

https://codereview.chromium.org/960753003/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:3918: -          Utility:
What do other utility processes (besides V8 Proxy Resolver) display for utility
type?

https://codereview.chromium.org/960753003/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/960753003/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:3918: +          Utility: <ph
name="UTILITY_TYPE">$1<ex>Utility</ex></ph>
Can you give a better example utility type?

[Anand Mistry (off Chromium), 2015-03-19 03:51:55]

Screenshot:
https://chromium.googlecode.com/issues/attachment?aid=4678320003000&name=task...

https://codereview.chromium.org/960753003/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (left):

https://codereview.chromium.org/960753003/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:3918: -          Utility:
On 2015/03/17 15:24:14, James Hawkins wrote:
> What do other utility processes (besides V8 Proxy Resolver) display for
utility
> type?

They just display "Utility: " today. This changes it to "Utility: utility
process" for everything other than the proxy resolver. Not very good, I agree.
But none of the other users of the utility process are long-lived, so don't
really need to identify themselves since they disappear after a few seconds.

This is a short to medium term solution. Longer term, since the proxy resolver
is a Mojo service, we'll run it and identify it in the same way we do other Mojo
services, whatever that may be.

https://codereview.chromium.org/960753003/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/960753003/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:3918: +          Utility: <ph
name="UTILITY_TYPE">$1<ex>Utility</ex></ph>
On 2015/03/17 15:24:14, James Hawkins wrote:
> Can you give a better example utility type?

Changed to "Image Decoder" as a realistic example (and one that exists today,
but isn't named per-se).

[James Hawkins, 2015-03-19 22:32:53]

LGTM with nit.

FWIW I can't access the screenshot you linked.

https://codereview.chromium.org/960753003/diff/60001/content/browser/utility_...
File content/browser/utility_process_host_impl.h (right):

https://codereview.chromium.org/960753003/diff/60001/content/browser/utility_...
content/browser/utility_process_host_impl.h:101: std::string name_;
nit: Document this member var (the others should be documented as well, but
that's outside the scope of this CL).

[Anand Mistry (off Chromium), 2015-03-20 01:03:04]

Wierd you can't see the screenshot. I attached it to crbug.com/467832 and the
issue is public.

https://codereview.chromium.org/960753003/diff/60001/content/browser/utility_...
File content/browser/utility_process_host_impl.h (right):

https://codereview.chromium.org/960753003/diff/60001/content/browser/utility_...
content/browser/utility_process_host_impl.h:101: std::string name_;
On 2015/03/19 22:32:53, James Hawkins wrote:
> nit: Document this member var (the others should be documented as well, but
> that's outside the scope of this CL).

Done.

[Anand Mistry (off Chromium), 2015-03-20 01:03:13]

The CQ bit was checked by amistry@chromium.org

[Anand Mistry (off Chromium), 2015-03-20 01:03:13]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
jhawkins@chromium.org
Link to the patchset: https://codereview.chromium.org/960753003/#ps80001 (title:
"Add comment.")

[commit-bot: I haz the power, 2015-03-20 01:03:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960753003/80001

[James Hawkins, 2015-03-20 01:06:42]

On 2015/03/20 01:03:04, Anand Mistry wrote:
> Wierd you can't see the screenshot. I attached it to crbug.com/467832 and the
> issue is public.
> 

For future reference, the URL contains (and requires) a token which is unique
per user, so the direct link to the image in crbug is not linkable (as far as I
understand it).

[commit-bot: I haz the power, 2015-03-20 02:07:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-20 02:08:06]

Patchset 5 (id:??) landed as
https://crrev.com/cd95c253cae9d0c2d53cdb1b899fa071906b65e5
Cr-Commit-Position: refs/heads/master@{#321495}