Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 96073002: Revert 237848 "Use LatencyInfoSwapPromise to track LatencyInfo t..." (Closed)

Created:
7 years ago by Dan Beam
Modified:
7 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 237848 "Use LatencyInfoSwapPromise to track LatencyInfo t..." Speculative revert to see if this broke views_unittests, event_unittests, and aura_unittests to be crashed or hung. Example: E:\b\build\slave\Win8_Aura\build\src\out\Debug\events_unittests.exe --brave-new-test-launcher --test-launcher-bot-mode --gtest_print_time --gtest_output=xml:E:\b\build\slave\Win8_Aura\build\gtest-results\events_unittests\events_unittests.xml IMPORTANT DEBUGGING NOTE: batches of tests are run inside their own process. For debugging a test inside a debugger, use the --gtest_filter=<your_test_name> flag along with --single-process-tests. Enabling defaults optimized for continuous integration bots. Using sharding settings from environment. This is shard 0/1 Using 8 parallel jobs. [1128/165136:ERROR:launch_win.cc(166)] : Access is denied. [1128/165136:ERROR:launch_win.cc(166)] : Access is denied. Failed to get out-of-band test success data, dumping full stdio below: [1/29] EventDispatcherTest.EventDispatchOrder (UNKNOWN) [2/29] EventDispatcherTest.EventDispatchPhase (UNKNOWN) [3/29] EventDispatcherTest.EventDispatcherDestroyedDuringDispatch (UNKNOWN) [4/29] EventDispatcherTest.EventDispatcherInvalidateTarget (UNKNOWN) [5/29] EventDispatcherTest.EventHandlerDestroyedDuringDispatch (UNKNOWN) [6/29] EventDispatcherTest.EventHandlerAndDispatcherDestroyedDuringDispatch (UNKNOWN) [7/29] LatencyInfoTest.AddTwoSeparateEvent (UNKNOWN) [8/29] LatencyInfoTest.AddTwoSameEvent (UNKNOWN) [9/29] LatencyInfoTest.MergeTwoSeparateEvent (UNKNOWN) [10/29] LatencyInfoTest.MergeTwoSameEvent (UNKNOWN) Too many badly broken tests (10), exiting now. [1128/165136:ERROR:launch_win.cc(166)] : Access is denied. Error: no element found: line 1, column 0 No data was available to update the JSON results exit code (as seen by runtest.py): 1 @@@STEP_FAILURE@@@ @@@STEP_TEXT@events_unittests@@@ @@@STEP_TEXT@crashed or hung@@@ > Use LatencyInfoSwapPromise to track LatencyInfo through compositor > > Originally we cache LatencyInfo directly in compositor. Now that > with the support of SwapPromise, we can use LatencyInfoSwapPromise > to track the LatencyInfo. > > BUG=246034 > TEST=Input LatencyInfo are still correctly passed to output surface > through LatencyInfoSwapPromise. > > Review URL: https://codereview.chromium.org/81533002 TBR=miletus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -169 lines) Patch
D trunk/src/cc/base/latency_info_swap_promise.h View 1 chunk +0 lines, -28 lines 0 comments Download
D trunk/src/cc/base/latency_info_swap_promise.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M trunk/src/cc/base/swap_promise.h View 3 chunks +5 lines, -7 lines 0 comments Download
M trunk/src/cc/cc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/cc/cc_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/trees/layer_tree_host.h View 3 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/trees/layer_tree_impl.h View 3 chunks +8 lines, -1 line 0 comments Download
M trunk/src/cc/trees/layer_tree_impl.cc View 4 chunks +19 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/content/renderer/gpu/render_widget_compositor.cc View 2 chunks +1 line, -4 lines 0 comments Download
M trunk/src/ui/compositor/compositor.cc View 2 chunks +1 line, -4 lines 0 comments Download
M trunk/src/ui/events/latency_info.h View 2 chunks +3 lines, -12 lines 0 comments Download
M trunk/src/ui/events/latency_info.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dan Beam
7 years ago (2013-11-29 01:26:39 UTC) #1
Dan Beam
7 years ago (2013-11-29 01:28:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r237857.

Powered by Google App Engine
This is Rietveld 408576698