Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 960693002: Remove NetworkChangeNotifierCast. (Closed)

Created:
5 years, 10 months ago by derekjchow1
Modified:
5 years, 10 months ago
Reviewers:
gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NetworkChangeNotifierCast. Cast will use NetworkChangeNotifierLinux. This commit also fixes a some logging messages and tear down in ConnectivityChecker. R=gunsch@chromium.org BUG=391064 Committed: https://crrev.com/44452c401a94b03f422144fcbed437bb04e325e5 Cr-Commit-Position: refs/heads/master@{#318156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -116 lines) Patch
M chromecast/browser/cast_browser_main_parts.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/net/connectivity_checker.cc View 3 chunks +4 lines, -1 line 0 comments Download
D chromecast/net/network_change_notifier_cast.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chromecast/net/network_change_notifier_cast.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D chromecast/net/network_change_notifier_factory_cast.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chromecast/net/network_change_notifier_factory_cast.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
derekjchow1
5 years, 10 months ago (2015-02-25 23:36:16 UTC) #1
gunsch
On 2015/02/25 23:36:16, derekjchow1 wrote: woo! lgtm
5 years, 10 months ago (2015-02-25 23:38:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960693002/1
5 years, 10 months ago (2015-02-25 23:47:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 00:34:46 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 00:35:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44452c401a94b03f422144fcbed437bb04e325e5
Cr-Commit-Position: refs/heads/master@{#318156}

Powered by Google App Engine
This is Rietveld 408576698