Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: testing/embedder_test.h

Issue 960663002: Implement a delegate for EmbedderTests. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Remove unused member Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/embedder_test.cpp » ('j') | testing/embedder_test.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/embedder_test.h
diff --git a/testing/embedder_test.h b/testing/embedder_test.h
index 072dce3bc3f2e508af441542593d7f065e080aa1..708b362d934c1b2f921556c93452b40f52ee1df8 100644
--- a/testing/embedder_test.h
+++ b/testing/embedder_test.h
@@ -9,6 +9,7 @@
#include "../core/include/fxcrt/fx_system.h"
#include "../fpdfsdk/include/fpdf_dataavail.h"
+#include "../fpdfsdk/include/fpdf_ext.h"
#include "../fpdfsdk/include/fpdfformfill.h"
#include "../fpdfsdk/include/fpdfview.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -18,25 +19,29 @@ class TestLoader;
// This class is used to load a PDF document, and then run programatic
// API tests against it.
-class EmbedderTest : public ::testing::Test {
+class EmbedderTest : public ::testing::Test,
+ public UNSUPPORT_INFO,
+ public IPDF_JSPLATFORM,
+ public FPDF_FORMFILLINFO {
public:
- EmbedderTest() :
- document_(nullptr),
- form_handle_(nullptr),
- avail_(nullptr),
- loader_(nullptr),
- file_length_(0),
- file_contents_(nullptr) {
- memset(&hints_, 0, sizeof(hints_));
- memset(&file_access_, 0, sizeof(file_access_));
- memset(&file_avail_, 0, sizeof(file_avail_));
- }
-
- virtual ~EmbedderTest() { }
+ class Delegate {
+ public:
+ virtual ~Delegate() { }
+ virtual void UnsupportedHandler(int type) { }
Lei Zhang 2015/02/25 23:02:51 Can you document these methods?
Tom Sepez 2015/02/25 23:25:22 Done.
+ virtual int Alert(FPDF_WIDESTRING message, FPDF_WIDESTRING title,
+ int type, int icon) {
+ return 0;
+ }
+ };
+
+ EmbedderTest();
+ virtual ~EmbedderTest();
void SetUp() override;
void TearDown() override;
+ void SetDelegate(Delegate* delegate) { delegate_ = delegate; }
+
FPDF_DOCUMENT document() { return document_; }
FPDF_FORMHANDLE form_handle() { return form_handle_; }
@@ -62,6 +67,8 @@ class EmbedderTest : public ::testing::Test {
virtual void UnloadPage(FPDF_PAGE page);
protected:
+ Delegate* delegate_;
+ Delegate* original_delegate_;
Lei Zhang 2015/02/25 23:02:51 s/original/default/ ?
Tom Sepez 2015/02/25 23:25:22 Done.
FPDF_DOCUMENT document_;
FPDF_FORMHANDLE form_handle_;
FPDF_AVAIL avail_;
@@ -73,6 +80,11 @@ class EmbedderTest : public ::testing::Test {
TestLoader* loader_;
size_t file_length_;
char* file_contents_;
+
+ private:
+ static void UnsupportedHandlerTrampoline(UNSUPPORT_INFO*, int type);
+ static int AlertTrampoline(IPDF_JSPLATFORM* plaform, FPDF_WIDESTRING message,
+ FPDF_WIDESTRING title, int type, int icon);
};
#endif // TESTING_EMBEDDER_TEST_H_
« no previous file with comments | « no previous file | testing/embedder_test.cpp » ('j') | testing/embedder_test.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698