Implement a delegate for EmbedderTests.

Implement a delegate for EmbedderTests.

This is the first step in allowing an embedder test to
someday gMock its callbacks, so that it can check that they
fired as expected. gMock wants a class, not a C-style
function-based API, and EmbedderTest is made to bridge
between the two.

The EmbedderTest class itself is modified to inherit from
the C JS API classes themselves, to make finding the
delegate easier.

For example, a future embedder test might send a keystroke
to a page, which would then trigger JS, which would then
trigger an Alert().  Mocking the Alert() callback would
allow the test to check that the alert happened as
expected.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/42a8adad1c53c060bb93457902243a53270cec36

[Tom Sepez, 2015-02-25 21:56:57]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-02-25 21:56:57]

Lei, please review.

[Lei Zhang, 2015-02-25 23:02:51]

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.cpp
File testing/embedder_test.cpp (left):

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.cp...
testing/embedder_test.cpp:189: FSDK_SetUnSpObjProcessHandler(&unsuppored_info);
I'm surprised this ever worked. Wouldn't |unsuppored_info| have been destroyed
at the end of the function?

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.cpp
File testing/embedder_test.cpp (right):

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.cp...
testing/embedder_test.cpp:205: UNSUPPORT_INFO *info =
static_cast<UNSUPPORT_INFO*>(this);
nit: * on the left

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.cp...
testing/embedder_test.cpp:325: if (test->delegate_) {
Should we just assume |delegate_| is always valid? i.e. SetDelegate(nullptr) is
disallowed.

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.h
File testing/embedder_test.h (right):

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.h#...
testing/embedder_test.h:30: virtual void UnsupportedHandler(int type) { }
Can you document these methods?

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.h#...
testing/embedder_test.h:71: Delegate* original_delegate_;
s/original/default/ ?

[Tom Sepez, 2015-02-25 23:25:23]

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.cpp
File testing/embedder_test.cpp (left):

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.cp...
testing/embedder_test.cpp:189: FSDK_SetUnSpObjProcessHandler(&unsuppored_info);
On 2015/02/25 23:02:50, Lei Zhang wrote:
> I'm surprised this ever worked. Wouldn't |unsuppored_info| have been destroyed
> at the end of the function?
I thought it copied its contents, but further inspection disproves that !!!

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.cpp
File testing/embedder_test.cpp (right):

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.cp...
testing/embedder_test.cpp:205: UNSUPPORT_INFO *info =
static_cast<UNSUPPORT_INFO*>(this);
On 2015/02/25 23:02:50, Lei Zhang wrote:
> nit: * on the left

Done.

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.cp...
testing/embedder_test.cpp:325: if (test->delegate_) {
On 2015/02/25 23:02:51, Lei Zhang wrote:
> Should we just assume |delegate_| is always valid? i.e. SetDelegate(nullptr)
is
> disallowed.
Yep.  In fact, we can make SetDelegate(0) mean restore default since we still
have it.

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.h
File testing/embedder_test.h (right):

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.h#...
testing/embedder_test.h:30: virtual void UnsupportedHandler(int type) { }
On 2015/02/25 23:02:51, Lei Zhang wrote:
> Can you document these methods?

Done.

https://codereview.chromium.org/960663002/diff/20001/testing/embedder_test.h#...
testing/embedder_test.h:71: Delegate* original_delegate_;
On 2015/02/25 23:02:51, Lei Zhang wrote:
> s/original/default/ ?

Done.

[Lei Zhang, 2015-02-25 23:34:32]

lgtm

[Tom Sepez, 2015-02-26 00:00:13]

Committed patchset #3 (id:40001) manually as
42a8adad1c53c060bb93457902243a53270cec36 (presubmit successful).