pkg/analysis_server/lib/src/protocol.dart - Issue 960653003: Use String.replaceRange() instead of concatenation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/protocol.dart

Issue 960653003: Use String.replaceRange() instead of concatenation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/protocol.dart

diff --git a/pkg/analysis_server/lib/src/protocol.dart b/pkg/analysis_server/lib/src/protocol.dart

index e5349433b8b7b9bfa4edd159b04cc0ff240e2d42..1f6f849d5c0af38f207f3cce5f17c287048c84f6 100644

--- a/pkg/analysis_server/lib/src/protocol.dart

+++ b/pkg/analysis_server/lib/src/protocol.dart

@@ -73,9 +73,7 @@ String _applyEdit(String code, SourceEdit edit) {

if (edit.length < 0) {

throw new RangeError('length is negative');

}

- return code.substring(0, edit.offset) +

- edit.replacement +

- code.substring(edit.end);

+ return code.replaceRange(edit.offset, edit.end, edit.replacement);

}

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »