Issue 960573002: fAddedToCache doesn't need to be atomic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 960573002: fAddedToCache doesn't need to be atomic. (Closed)

Created:
5 years, 10 months ago by mtklein_C

Modified:
5 years, 10 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

fAddedToCache doesn't need to be atomic. It's only ever read or set from non-threadsafe methods. BUG=skia: Committed: https://skia.googlesource.com/skia/+/fbe0edfec4fed2a09e12b049d527d280f16e75b3

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	include/core/SkPixelRef.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	src/core/SkPixelRef.cpp	View		3 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960573002/1

5 years, 10 months ago (2015-02-25 16:05:03 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/fbe0edfec4fed2a09e12b049d527d280f16e75b3

5 years, 10 months ago (2015-02-25 16:11:23 UTC) #6

mtklein

5 years, 10 months ago (2015-02-25 16:26:41 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/959763002/ by mtklein@google.com.

The reason for reverting is: Yes it does.  notifyAddedToCache() must be
thread-safe..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages