Issue 960563002: only notify bitmaps that have been added to the cache

Issue 960563002: only notify bitmaps that have been added to the cache (Closed)

Created:
5 years, 10 months ago by reed1

Modified:
5 years, 10 months ago

Reviewers:
mtklein, f(malita)

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

only notify bitmaps that have been added to the cache old code: - calls=2677 hit-rate=3.51139% new code: - calls=94 hit-rate=97.8723% BUG=skia: Committed: https://skia.googlesource.com/skia/+/83787d0ff0a2b2f839a4a3ce6dadd033f83fe643

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -20 lines)			Patch
M	include/core/SkPixelRef.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/core/SkBitmapCache.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkBitmapCache.cpp	View	1	5 chunks	+6 lines, -2 lines	0 comments	Download
M	src/core/SkPixelRef.cpp	View	1	3 chunks	+7 lines, -4 lines	0 comments	Download
M	src/core/SkResourceCache.cpp	View		2 chunks	+23 lines, -0 lines	0 comments	Download
M	src/gpu/SkGrPixelRef.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/lazy/SkCachingPixelRef.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/SkResourceCacheTest.cpp	View		4 chunks	+12 lines, -10 lines	0 comments	Download

Total messages: 8 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960563002/20001

5 years, 10 months ago (2015-02-25 15:01:32 UTC) #5

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

5 years, 10 months ago (2015-02-25 15:01:33 UTC) #6

commit-bot: I haz the power

5 years, 10 months ago (2015-02-25 15:17:16 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/83787d0ff0a2b2f839a4a3ce6dadd033f83fe643