Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: src/parser.h

Issue 960543002: Move compilation error handling into a separate class. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | src/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parser.h
diff --git a/src/parser.h b/src/parser.h
index 26255b28cb4b947128401a77db1fb321113d2edf..f5bb792110d6e0751d68cfd3d5b0a5e5ad620151 100644
--- a/src/parser.h
+++ b/src/parser.h
@@ -8,6 +8,7 @@
#include "src/allocation.h"
#include "src/ast.h"
#include "src/compiler.h" // For CachedDataMode
+#include "src/pending-compilation-error-handler.h"
#include "src/preparse-data.h"
#include "src/preparse-data-format.h"
#include "src/preparser.h"
@@ -843,13 +844,7 @@ class Parser : public ParserBase<ParserTraits> {
bool parsing_lazy_arrow_parameters_; // for lazily parsed arrow functions.
- // Pending errors.
- bool has_pending_error_;
- Scanner::Location pending_error_location_;
- const char* pending_error_message_;
- const AstRawString* pending_error_arg_;
- const char* pending_error_char_arg_;
- ParseErrorType pending_error_type_;
+ PendingCompilationErrorHandler pending_error_handler_;
// Other information which will be stored in Parser and moved to Isolate after
// parsing.
« no previous file with comments | « BUILD.gn ('k') | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698