Issue 960543002: Move compilation error handling into a separate class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 960543002: Move compilation error handling into a separate class. (Closed)

Created:
5 years, 9 months ago by marja

Modified:
5 years, 9 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Move compilation error handling into a separate class. In addition to Parser, other phases (such as scope analysis) need to handle compilation errors in the future. PendingCompilationErrorHandled takes care of error handling in a unified way. Split from https://codereview.chromium.org/943543002/ . R=rossberg@chromium.org BUG= Committed: https://crrev.com/238ad54d0f8634376dae2246070602af101f63ad Cr-Commit-Position: refs/heads/master@{#26853}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+153 lines, -76 lines)			Patch
M	BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/parser.h	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	src/parser.cc	View	5 chunks	+8 lines, -69 lines	0 comments	Download
A	src/pending-compilation-error-handler.h	View	1 chunk	+77 lines, -0 lines	0 comments	Download
A	src/pending-compilation-error-handler.cc	View	1 chunk	+62 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960543002/1

5 years, 9 months ago (2015-02-25 13:50:54 UTC) #3

commit-bot: I haz the power

5 years, 9 months ago (2015-02-25 14:18:42 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/238ad54d0f8634376dae2246070602af101f63ad
Cr-Commit-Position: refs/heads/master@{#26853}