Sync the DOMImplementation interface with the spec

Source/core/dom/DOMImplementation.idl

 /*
  * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
+// https://dom.spec.whatwg.org/#interface-domimplementation
+
 [
     SetWrapperReferenceFrom=document,
     TypeChecking=Interface,
     WillBeGarbageCollected,
 ] interface DOMImplementation {
+    [RaisesException] DocumentType createDocumentType(DOMString qualifiedName, DOMString publicId, DOMString systemId);
+    [RaisesException] XMLDocument createDocument(DOMString? namespaceURI, [TreatNullAs=EmptyString] DOMString qualifiedName, optional DocumentType? doctype = null);

[haraken, 2015/02/25 17:25:41]

I'm wondering if we need '= null'. I guess it's just redundant. This is a
question not to your CL but to the spec though.

Jens?

[Jens Widell, 2015/02/25 17:32:56]

"= null" says "treat missing the same as if null was passed". The spec prose
then only needs to explain two cases: "null" and "a DocumentType object".

Without "= null", the spec prose would also need to explain the "missing" case.
(Probably by saying "if missing or null, do X".)

In Blink, we'd need to explicitly implement the "missing" case to behave the
same as null as well, without "= null". Now the implementation just sees a
pointer, always with a valid value, possibly null.

Everybody wins. :-)

+    // FIXME: createHTMLDocument should return a Document. crbug.com/238368
+    HTMLDocument createHTMLDocument(optional DOMString title);
 
-    // DOM Level 1
-
+    // FIXME: hasFeature should take no arguments and always return true. crbug.com/429536
     [ImplementedAs=hasFeatureForBindings, MeasureAs=DOMImplementationHasFeature]
     boolean hasFeature(DOMString feature, DOMString? version);
-
-    // DOM Level 2
-
-    [RaisesException] DocumentType createDocumentType(DOMString qualifiedName,
-                                                      DOMString publicId,
-                                                      DOMString systemId);
-    [RaisesException] XMLDocument createDocument(DOMString? namespaceURI,
-                                                 [TreatNullAs=EmptyString] DOMString qualifiedName,
-                                                 optional DocumentType? doctype = null);
-
-    // HTMLDOMImplementation interface from DOM Level 2 HTML
-
-    HTMLDocument createHTMLDocument(optional DOMString title = null);
 };