src/snapshot-common.cc - Issue 960513002: Fix assertion when creating custom startup snapshots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/snapshot-common.cc

Issue 960513002: Fix assertion when creating custom startup snapshots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/snapshot-common.cc

diff --git a/src/snapshot-common.cc b/src/snapshot-common.cc

index 637bac0f4d174a356c2f79f0b64e0360fd0cafd0..d60af0cab94130fbf8339b525cc57fe5cd60239a 100644

--- a/src/snapshot-common.cc

+++ b/src/snapshot-common.cc

@@ -155,7 +155,7 @@ v8::StartupData Snapshot::CreateSnapshotBlob(

uint32_t first_page_sizes[kNumPagedSpaces];

- CalculateFirstPageSizes(metadata.embeds_script(), startup_snapshot,

+ CalculateFirstPageSizes(!metadata.embeds_script(), startup_snapshot,

context_snapshot, first_page_sizes);

int startup_length = startup_data.length();

« no previous file with comments | « no previous file | no next file » | no next file with comments »