Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 960513002: Fix assertion when creating custom startup snapshots. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix assertion when creating custom startup snapshots. R=vogelheim@chromium.org Committed: https://crrev.com/f9fd33c10ff195671574ced64056399f2bc73f6e Cr-Commit-Position: refs/heads/master@{#26850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/snapshot-common.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 10 months ago (2015-02-25 10:24:21 UTC) #1
vogelheim
lgtm
5 years, 10 months ago (2015-02-25 12:56:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960513002/1
5 years, 10 months ago (2015-02-25 13:31:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 13:56:06 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 13:56:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9fd33c10ff195671574ced64056399f2bc73f6e
Cr-Commit-Position: refs/heads/master@{#26850}

Powered by Google App Engine
This is Rietveld 408576698