Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/FilesView.java

Issue 9605022: "Remove" nomenclature refinement and Files View context menu rejigger. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/FilesView.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/FilesView.java (revision 5047)
+++ editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/FilesView.java (working copy)
@@ -19,6 +19,7 @@
import com.google.dart.tools.ui.actions.CopyFilePathAction;
import com.google.dart.tools.ui.actions.DeleteAction;
import com.google.dart.tools.ui.internal.actions.CollapseAllAction;
+import com.google.dart.tools.ui.internal.handlers.OpenFolderHandler;
import com.google.dart.tools.ui.internal.preferences.DartBasePreferencePage;
import com.google.dart.tools.ui.internal.projects.CreateFileWizard;
import com.google.dart.tools.ui.internal.projects.CreateFolderWizard;
@@ -291,30 +292,43 @@
manager.add(createFileAction);
manager.add(createFolderAction);
- // Rename... / Move..., iff single element and is an IResource
+ // OPEN GROUP
+ manager.add(new Separator());
+ manager.add(OpenFolderHandler.createCommandAction(getSite().getWorkbenchWindow()));
+
IStructuredSelection selection = (IStructuredSelection) treeViewer.getSelection();
- Object element = selection.getFirstElement();
- if (selection.size() == 1 && element instanceof IResource) {
+
+ // REFACTOR GROUP
+
+ // Refactor iff all elements are IResources
+
+ if (!selection.isEmpty() && allElementsAreResources(selection)) {
manager.add(new Separator());
- manager.add(renameAction);
- manager.add(moveAction);
+ if (selection.size() == 1) {
+ manager.add(renameAction);
+ manager.add(moveAction);
+ }
+ manager.add(deleteAction);
}
- // Delete, iff non-empty selection, all elements are IResources
+ // Remove, iff non-empty selection, all elements are IResources
if (!selection.isEmpty() && allElementsAreResources(selection)) {
+
+ // Copy File Path iff single element and is an IResource
+
+ if (selection.size() == 1) {
+ manager.add(new Separator());
+ manager.add(copyFilePathAction);
+ }
+
manager.add(new Separator());
if (allElementsAreProjects(selection)) {
manager.add(hideContainerAction);
}
- manager.add(deleteAction);
}
- // Copy File Path
-
- manager.add(new Separator());
- manager.add(copyFilePathAction);
}
protected void fillInToolbar(IToolBarManager toolbar) {

Powered by Google App Engine
This is Rietveld 408576698