Support federated credentials in Chrome settings.

Support federated credentials in Chrome settings.

chrome://settings/passwords currently displays a blank input field for
federated credentials. This patch adjusts things to support displaying
the hostname of the federation with which the credential is bound. That
is, it will display "via facebook.com" if you've signed into a website
using Facebook, and saved that credential via the Credential Manager
API.

BUG=461800
R=vasilii@chromium.org

Committed: https://crrev.com/02557130c2bfa0b5261a29e792e03835d88f58ef
Cr-Commit-Position: refs/heads/master@{#322146}

[Mike West, 2015-02-25 13:28:10]

Hi Vasilii!

Would you mind skimming this for sanity before I hand it to a WebUI OWNER?

-mike

[vasilii, 2015-02-25 13:53:30]

lgtm

https://codereview.chromium.org/960493004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/960493004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:7602: +      <message
name="IDS_PASSWORDS_VIA_FEDERATION" desc="Text for federated credential's
value.">
Do you want to reuse IDS_MANAGE_PASSWORDS_IDENTITY_PROVIDER?

[Mike West, 2015-02-25 20:38:45]

mkwst@chromium.org changed reviewers:
+ dbeam@chromium.org

[Mike West, 2015-02-25 20:38:46]

dbeam@: Mind taking a look with your OWNERS hat on?

vasilii@: I figured it was safer to have a separate message, but I'm happy to
combine them if that's the right thing to do.

[Mike West, 2015-02-28 06:35:36]

Friendly ping. :)

[Dan Beam, 2015-03-03 22:49:54]

lgtm

https://codereview.chromium.org/960493004/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/password_manager_list.js (right):

https://codereview.chromium.org/960493004/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager_list.js:17: *     may be
present.
nit:

  /** @const {number} */ var URL_DATA_INDEX = 0;
  /** @const {number} */ var USERNAME_DATA_INDEX = 1;

  this.dataItem[URL_DATA_INDEX]

or used named keys, e.g.,

  this.dataItem = {
    'url': entry[0],
    ...
  };

https://codereview.chromium.org/960493004/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager_list.js:341: if (item &&
item.length > 4) {
nit:

  if (item && item[FEDERATION_INDEX]) {  // or item[4]

is simpler, IMO (and I don't think there's a way a federation could be "" and
fail this check)

https://codereview.chromium.org/960493004/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/password_manager_handler.cc (right):

https://codereview.chromium.org/960493004/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/password_manager_handler.cc:204: }
nit:

  const GURL& federation_url = password_list[i]->federation_url;
  if (!federation_url.is_empty()) {
    entry->AppendString(l10n_util::GetStringFUTF16(IDS_PASSWORDS_VIA_FEDERATION,
                                                   federation_url.host());
  }

[Mike West, 2015-03-25 11:56:29]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-03-25 11:56:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
vasilii@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/960493004/#ps20001 (title:
"Nits")

[commit-bot: I haz the power, 2015-03-25 11:56:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960493004/20001

[commit-bot: I haz the power, 2015-03-25 12:53:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-25 12:54:46]

Patchset 2 (id:??) landed as
https://crrev.com/02557130c2bfa0b5261a29e792e03835d88f58ef
Cr-Commit-Position: refs/heads/master@{#322146}