Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 960423004: Switched variable naming style from camelCase to hacker_style in BrowserCommandsTests (Closed)

Created:
5 years, 10 months ago by sarka
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switched variable naming style from camelCase to hacker_style in BrowserCommandsTests(browser_command_unittests). This is a followup CL to https://codereview.chromium.org/678343002/. BUG=none Committed: https://crrev.com/93c53be1cb22bfaec6b5c201ddd6150a813acaf6 Cr-Commit-Position: refs/heads/master@{#318470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M chrome/browser/browser_commands_unittest.cc View 8 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
sarka
On 2015/02/27 02:07:48, sarka wrote: > mailto:a.sarkar.arun@gmail.com changed reviewers: > + mailto:asvitkine@chromium.org, mailto:jochen@chromium.org PTAL. Thanks
5 years, 10 months ago (2015-02-27 02:08:03 UTC) #2
jochen (gone - plz use gerrit)
i agree that this violates the coding style, but without any other benefit, I don't ...
5 years, 10 months ago (2015-02-27 09:12:24 UTC) #3
sarka
On 2015/02/27 09:12:24, jochen (slow) wrote: > i agree that this violates the coding style, ...
5 years, 9 months ago (2015-02-27 13:41:15 UTC) #4
jochen (gone - plz use gerrit)
ok, can you please update the CL description then to say that it's a follow-up ...
5 years, 9 months ago (2015-02-27 13:43:01 UTC) #5
Alexei Svitkine (slow)
LGTM format for BUG= line when there's no bug, is BUG=none
5 years, 9 months ago (2015-02-27 16:30:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960423004/1
5 years, 9 months ago (2015-02-27 16:35:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 17:10:18 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 17:11:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93c53be1cb22bfaec6b5c201ddd6150a813acaf6
Cr-Commit-Position: refs/heads/master@{#318470}

Powered by Google App Engine
This is Rietveld 408576698