Issue 960363002: Revert of Also skip when the target is the global object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 960363002: Revert of Also skip when the target is the global object (Closed)

Created:
5 years, 10 months ago by Michael Achenbach

Modified:
5 years, 10 months ago

Reviewers:
Toon Verwaest, Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Also skip when the target is the global object (patchset #1 id:1 of https://codereview.chromium.org/961723002/) Reason for revert: Breaks unscopables and fix attempt needed to be reverted too. Original issue's description: > Also skip when the target is the global object > > BUG= > > Committed: https://crrev.com/cc918d30b9d586ce974b71232473f2ae3c5e7847 > Cr-Commit-Position: refs/heads/master@{#26887} TBR=jkummerow@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/27a3879617245f347213a739eee3727e24a0c608 Cr-Commit-Position: refs/heads/master@{#26900}

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -8 lines)			Patch
M	src/ic/arm/handler-compiler-arm.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/ic/arm64/handler-compiler-arm64.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/ic/ia32/handler-compiler-ia32.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/ic/x64/handler-compiler-x64.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of Also skip when the target is the global object

5 years, 10 months ago (2015-02-26 21:03:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960363002/1

5 years, 10 months ago (2015-02-26 21:03:49 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-26 21:04:43 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/27a3879617245f347213a739eee3727e24a0c608
Cr-Commit-Position: refs/heads/master@{#26900}